feat(blocks): support _ in block names and deprecate v1 #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecates V1 blocks by way of a persistent log message any time a v1 block is read from disk. Adds support for `_` in block names.
Deploying stencil with
|
| Latest commit: |
1811cd0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3d4b3283.stencil-1wj.pages.dev |
| Branch Preview URL: | https://jaredallard-feat-support-und.stencil-1wj.pages.dev |
|
FYI @malept |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
PR Overview
This PR adds support for underscores in block names and deprecates V1 blocks with a persistent warning message when a V1 block is read from disk. Key changes include:
- Updating tool versions in .mise.toml and commenting out the old golangci-lint configuration.
- Modifying the linters workflow to retrieve the new golangci-lint version.
- Adding a deprecation warning for V1 blocks and updating block version handling and tests accordingly.
Reviewed Changes
| File | Description |
|---|---|
| .mise.toml | Updated golang tool versions and replaced the old golangci-lint entry |
| .github/workflows/linters.yaml | Changed the command to retrieve golangci-lint version, potentially affecting shell quoting |
| internal/codegen/file.go | Added a deprecation warning for V1 blocks |
| internal/codegen/blocks.go | Introduced BlockVersion type and updated regex to support "_" in block names |
| internal/codegen/blocks_test.go | Updated test helpers to use a test logger and pass in the testing context |
| internal/codegen/template_test.go | Updated usage of fakeBlocksTemplate to use the new signature |
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
deregtd
approved these changes
Mar 5, 2025
jaredallard
deleted the
jaredallard/feat/support-underscore-blocks-deprecate-v1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates V1 blocks by way of a persistent log message any time a v1
block is read from disk.
Adds support for
_in block names.