-
Notifications
You must be signed in to change notification settings - Fork 193
Support for Python 3.12 #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @liopeer! 👋🏻 Thanks so much for your interest in RF-DETR. I ran into the same issues locally using Python 3.13. I agree—the third option seems like the cleanest solution to me as well. @probicheaux @isaacrob-roboflow do we have a specific reason for including |
Same problem here as well! Doesn't work with Ubuntu24.04 + Python3.12.3 + cmake3.28.3 I second to @liopeer's suggestions to make all onnx dependencies optional. To be honest, the Traceback (most recent call last):
File "~/.venv-3.10/lib/python3.10/site-packages/onnxsim/onnx_simplifier.py", line 19, in <module>
import onnxruntime as rt # type: ignore
ModuleNotFoundError: No module named 'onnxruntime' and also, as pointed out, onnx is not needed for every situtaion. |
Good point @yutong-xiang-97 ! |
I am happy to see them moved to optional! |
@isaacrob-roboflow I'm working on PR now |
I've just merged the fix into the |
Search before asking
Bug
Hi,
I struggle to get
rfdetr
installed under Python 3.12, because of theonnxsim
dependency. That package does not officially support Python 3.12 and they therefore does not ship any pre-built wheels for it & my cmake seems also not able to build the package (Ubuntu 22.04, cmake 3.22.1 and macOS Sequoia, cmake 4.0.0).With it being annoying to install, it would be really nice to see one of the following solutions implemented:
pip install "rfdetr[onnxexport]"
Environment
Minimal Reproducible Example
pip install rfdetr
orpip install onnxsim
Additional
The issue of missing wheels is also mentioned here: daquexian/onnx-simplifier#334
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: