Unset flex property on navbar-right container (#286)

cpsievert · web-flow · commit df10a878e0e9 · 2021-03-17T16:01:53.000-05:00
* Close rstudio/flexdashboard#316: unset flex property on navbar-right container * Resave data (GitHub Action) * Just undo the flex: 1 as it doesn't seem needed in the first place * Set margin-left:auto since this is the BS4 recommendation * Resave data (GitHub Action) * Update news Co-authored-by: cpsievert <cpsievert@users.noreply.github.com>
diff --git a/NEWS.md b/NEWS.md
@@ -4,6 +4,7 @@
 * Closed #251: Added new BS4 Sass variables, `$navbar-light-bg` and `$navbar-dark-bg`, for more easily customizing the navbar's background color (#253)
 * Closed #236, #230, #242, #187, #215, #250: Addressed various cosmetic issues with CSS (#249). 
 * Closed #227: bs_themer() now overlays a spinner during Sass compilation (#243).
+* Closed https://github.com/rstudio/flexdashboard/issues/316: fixed bug with navbar nav alignment (#286).
 
 # bslib 0.2.4
 
diff --git a/inst/bs3compat/_navbar_compat.scss b/inst/bs3compat/_navbar_compat.scss
@@ -20,13 +20,8 @@
   @extend .sticky-top;
 }
 
-ul.nav.navbar-nav {
-  flex: 1;
-  -webkit-flex: 1;
-  &.navbar-right {
-    justify-content: flex-end;
-    -webkit-justify-content: flex-end;
-  }
+.navbar-nav.navbar-right {
+  margin-left: auto;
 }
 
 ul.nav.navbar-nav>li:not(.dropdown) {
diff --git a/inst/css-precompiled/4/bootstrap.min.css b/inst/css-precompiled/4/bootstrap.min.css

Original file line number	Diff line number	Diff line change
`@@ -20,13 +20,8 @@`
`20`	`20`	`@extend .sticky-top;`
`21`	`21`	`}`
`22`	`22`
`23`		`-ul.nav.navbar-nav {`
`24`		`- flex: 1;`
`25`		`- -webkit-flex: 1;`
`26`		`- &.navbar-right {`
`27`		`- justify-content: flex-end;`
`28`		`- -webkit-justify-content: flex-end;`
`29`		`- }`
	`23`	`+.navbar-nav.navbar-right {`
	`24`	`+ margin-left: auto;`
`30`	`25`	`}`
`31`	`26`
`32`	`27`	`ul.nav.navbar-nav>li:not(.dropdown) {`