Skip to content

Migrate to pre-commit.ci for pre-commit checks #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nathanjmcdougall opened this issue Jul 19, 2024 · 2 comments
Open

Migrate to pre-commit.ci for pre-commit checks #255

nathanjmcdougall opened this issue Jul 19, 2024 · 2 comments
Labels
.maint upkeep and maintenance of the pkg

Comments

@nathanjmcdougall
Copy link
Contributor

Currently the Code Checks workflow is emitting a few warnings.

One of them is the following:
Run pre-commit

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-python@v4, pre-commit/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The pre-commit/action README has the following message;
https://github.com/pre-commit/action

this action is in maintenance-only mode and will not be accepting new features.
generally you want to use pre-commit.ci which is faster and has more features.

I think we should consider performing the migration to pre-comit.ci.

@isabelizimm isabelizimm added the .maint upkeep and maintenance of the pkg label Jul 25, 2024
@nathanjmcdougall
Copy link
Contributor Author

I think the first thing is to enable to pre-commit.ci GitHub App:
https://pre-commit.ci/
It will start working without any config since we have pre-commit-config.yaml

Then, once it's working, a PR can be opened to remove the existing CI step.

@nathanjmcdougall
Copy link
Contributor Author

@isabelizimm The pipeline in https://github.com/rstudio/pins-python/actions/runs/14583410776/job/40904471773?pr=327 is failing. It might be fixed by bumping the version of pre-commit/action from v2.03 to the latest version v3.0.1. But it also might be time to migrate to the pre-commit.ci service, or just calling pre-commit directly with something like

      - name: Run pre-commit
        if: matrix.pre-commit
        run: |
          pre-commit run --all-files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.maint upkeep and maintenance of the pkg
Projects
None yet
Development

No branches or pull requests

2 participants