Skip to content

Commit f0da000

Browse files
akpm00sfrothwell
authored andcommitted
lib-test_bitmapc-add-for_each_set_clump-test-cases-checkpatch-fixes
ERROR: that open brace { should be on the previous line torvalds#151: FILE: lib/test_bitmap.c:648: +static struct clump_test_data_params clump_test_data[] __initdata = + { {{0}, 2, 0, 64, 8, clump_exp1}, ERROR: that open brace { should be on the previous line torvalds#161: FILE: lib/test_bitmap.c:658: + for(i = 0; i < clump_test_data[index].count; i++) + { ERROR: space required before the open parenthesis '(' torvalds#161: FILE: lib/test_bitmap.c:658: + for(i = 0; i < clump_test_data[index].count; i++) ERROR: that open brace { should be on the previous line torvalds#169: FILE: lib/test_bitmap.c:666: +static void __init execute_for_each_set_clump_test(unsigned int index) +{ WARNING: suspect code indent for conditional statements (8, 8) torvalds#173: FILE: lib/test_bitmap.c:670: + for_each_set_clump(start, clump, clump_test_data[index].data, [...] + expect_eq_clump(start, clump_test_data[index].limit, clump_test_data[index].exp, ERROR: that open brace { should be on the previous line torvalds#180: FILE: lib/test_bitmap.c:677: +static void __init test_for_each_set_clump(void) +{ total: 5 errors, 1 warnings, 174 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/lib-test_bitmapc-add-for_each_set_clump-test-cases.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Syed Nayyar Waris <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Stephen Rothwell <[email protected]>
1 parent f6b13da commit f0da000

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

lib/test_bitmap.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -655,8 +655,7 @@ static void __init prepare_test_data(unsigned int index)
655655
int i;
656656
unsigned long width = 0;
657657

658-
for(i = 0; i < clump_test_data[index].count; i++)
659-
{
658+
for (i = 0; i < clump_test_data[index].count; i++) {
660659
bitmap_set_value(clump_test_data[index].data,
661660
clump_bitmap_data[(clump_test_data[index].offset)++], width, 32);
662661
width += 32;

0 commit comments

Comments
 (0)