Skip to content

Commit a09e295

Browse files
committed
Update for review comments.
1 parent c057b87 commit a09e295

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/cargo/core/compiler/fingerprint.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@
8484
//! `RUST_LOG=cargo::core::compiler::fingerprint=trace cargo build` can be
8585
//! used to display this log information.
8686
//! - A "dep-info" file which contains a list of source filenames for the
87-
//! target. This is produced by `rustc`'s `--emit=dep-info` flag. Cargo uses
88-
//! this to check the mtime of every file to see if any of them have
89-
//! changed.
87+
//! target. This is produced by reading the output of `rustc
88+
//! --emit=dep-info` and packing it into a condensed format. Cargo uses this
89+
//! to check the mtime of every file to see if any of them have changed.
9090
//! - An `invoked.timestamp` file whose filesystem mtime is updated every time
9191
//! the Unit is built. This is an experimental feature used for cleaning
9292
//! unused artifacts.
@@ -735,7 +735,7 @@ pub fn prepare_build_cmd<'a, 'cfg>(
735735
// again. This should only find 1 dependency (for the build script) or 0
736736
// (if it is overridden).
737737
//
738-
// Note that this filters out `RunCustomBuild` units. These are `links`
738+
// FIXME: This filters out `RunCustomBuild` units. These are `links`
739739
// build scripts. Unfortunately, for many reasons, those would be very
740740
// difficult to include, so for now this is slightly wrong. Reasons:
741741
// Fingerprint::locals has to be rebuilt in the closure, LocalFingerprint
@@ -796,7 +796,7 @@ pub fn prepare_build_cmd<'a, 'cfg>(
796796
fingerprint.local = local_fingerprints_deps(&deps, &target_root, &pkg_root);
797797
fingerprint.update_local(&target_root)?;
798798
}
799-
// Note: If a build script switches from new style to old style,
799+
// FIXME: If a build script switches from new style to old style,
800800
// this is bugged. It should recompute Fingerprint::local, but
801801
// requires access to Context which we don't have here.
802802
// See https://github.com/rust-lang/cargo/issues/6779

0 commit comments

Comments
 (0)