Skip to content

Commit 116aaf3

Browse files
committed
ci: test windows dyn link
This requires an upstream bug-fix from cargo-c. To support dynamic linking on windows ensure you are using cargo-c 0.10.7+. With this in place, we can run integration tests against client/server binaries that dynamically link librustls.dll \o/
1 parent 3b0b18e commit 116aaf3

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/workflows/test.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -196,10 +196,9 @@ jobs:
196196
dyn_link: [ off ]
197197
include:
198198
# One build with dynamic linking.
199-
# TODO(@cpu): debug broken dyn-link build on Windows.
200-
# - crypto: aws-lc-rs
201-
# config: Release
202-
# dyn_link: on
199+
- crypto: aws-lc-rs
200+
config: Release
201+
dyn_link: on
203202
# One build with cert_compression.
204203
- crypto: aws-lc-rs
205204
config: Release
@@ -221,6 +220,7 @@ jobs:
221220
with:
222221
arch: x64
223222

223+
# Note: must use cargo-c 0.10.7+ for dynamic linking support on Windows.
224224
- name: Install cargo-c
225225
env:
226226
LINK: https://github.com/lu-zero/cargo-c/releases/latest/download

0 commit comments

Comments
 (0)