Merge pull request #35 from Carl-Foster/fix/oneOf-ref-resolution-loss

fix: oneOf step loses compiled reference resolution

Author: sagold

lib/step.ts

@@ -144,7 +144,6 @@ const stepType = {
 
                 const oneOfIndex = targetSchema.oneOf.findIndex((s) => s === resolvedSchema);
 
-                resolvedSchema = JSON.parse(JSON.stringify(resolvedSchema));
                 resolvedSchema.variableSchema = true;
                 resolvedSchema.oneOfIndex = oneOfIndex;
                 resolvedSchema.oneOfSchema = targetSchema;

test/unit/step/step.oneOf.test.ts

@@ -52,4 +52,36 @@ describe("step.oneof", () => {
 
         expect(res.oneOfIndex).to.eq(1);
     });
+
+    it("should maintain references from a remote schema when resolving oneOf with $ref", () => {
+        core.addRemoteSchema("https://my-other-schema.com/schema.json", {
+            type: "object",
+            properties: {
+                innerTitle: { $ref: "#/definitions/number" }
+            },
+            definitions: {
+                number: { type: "number", title: "Zahl" }
+            }
+        });
+        const schema = core.compileSchema({
+            type: "object",
+            properties: {
+                title: {
+                    oneOf: [
+                        {
+                            type: "object",
+                            properties: { innerTitle: { type: "string", title: "Zeichenkette" } }
+                        },
+                        { $ref: "https://my-other-schema.com/schema.json" }
+                    ]
+                }
+            }
+        });
+        const res = step(core, "title", schema, { title: { innerTitle: 111 } });
+
+        expect(res.type).to.eq("object");
+
+        const nextRes = step(core, "innerTitle", res, { innerTitle: 111 });
+        expect(nextRes.type).to.eq("number");
+    });
 });