Skip to content

Commit d3c7020

Browse files
committed
src: organize TLSWrap declarations by parent
Make it clear which of the multiple interfaces a TLSWrap method is implementing by grouping and commenting the related methods. PR-URL: nodejs#25861 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent 38838af commit d3c7020

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

src/tls_wrap.h

+13-12
Original file line numberDiff line numberDiff line change
@@ -56,16 +56,19 @@ class TLSWrap : public AsyncWrap,
5656
v8::Local<v8::Value> unused,
5757
v8::Local<v8::Context> context);
5858

59-
int GetFD() override;
59+
// Implement StreamBase:
6060
bool IsAlive() override;
6161
bool IsClosing() override;
62-
63-
// JavaScript functions
64-
int ReadStart() override;
65-
int ReadStop() override;
66-
62+
bool IsIPCPipe() override;
63+
int GetFD() override;
6764
ShutdownWrap* CreateShutdownWrap(
6865
v8::Local<v8::Object> req_wrap_object) override;
66+
AsyncWrap* GetAsyncWrap() override;
67+
68+
69+
// Implement StreamResource:
70+
int ReadStart() override; // Exposed to JS
71+
int ReadStop() override; // Exposed to JS
6972
int DoShutdown(ShutdownWrap* req_wrap) override;
7073
int DoWrite(WriteWrap* w,
7174
uv_buf_t* bufs,
@@ -78,8 +81,8 @@ class TLSWrap : public AsyncWrap,
7881

7982
void NewSessionDoneCb();
8083

84+
// Implement MemoryRetainer:
8185
void MemoryInfo(MemoryTracker* tracker) const override;
82-
8386
SET_MEMORY_INFO_NAME(TLSWrap)
8487
SET_SELF_SIZE(TLSWrap)
8588

@@ -135,13 +138,11 @@ class TLSWrap : public AsyncWrap,
135138
}
136139
}
137140

138-
AsyncWrap* GetAsyncWrap() override;
139-
bool IsIPCPipe() override;
140-
141-
// Resource implementation
142-
void OnStreamAfterWrite(WriteWrap* w, int status) override;
141+
// Implement StreamListener:
142+
// Returns buf that points into enc_in_.
143143
uv_buf_t OnStreamAlloc(size_t size) override;
144144
void OnStreamRead(ssize_t nread, const uv_buf_t& buf) override;
145+
void OnStreamAfterWrite(WriteWrap* w, int status) override;
145146

146147
v8::Local<v8::Value> GetSSLError(int status, int* err, std::string* msg);
147148

0 commit comments

Comments
 (0)