Skip to content

Commit a79d7d1

Browse files
committed
only depend on specific components of linkeddata being used
To avoid dependency conflicts with sub-dependencies of linkeddata not being used. linkeddata is a meta gem that just aggregates a bunch of linked data-related gems. We still aren't sure why these linkeddata gems have historically been listed as development-only dependencies instead of runtime dependencies. See #375
1 parent 2ddec23 commit a79d7d1

File tree

3 files changed

+15
-11
lines changed

3 files changed

+15
-11
lines changed

qa.gemspec

+9-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,15 @@ Gem::Specification.new do |s|
3030
s.add_development_dependency 'rails', '!=5.2.0', '!=5.2.1', '!=5.2.2'
3131
s.add_development_dependency 'byebug'
3232
s.add_development_dependency 'engine_cart', '~> 2.0'
33-
s.add_development_dependency 'linkeddata'
33+
34+
# Not sure why these RDF-related gems are only being listed as development dependencies
35+
# not general runtime dependencies...
36+
# ... maybe meant to be optional dependencies only if you are using related
37+
# func? See also the "meta" gem `linkeddata` which includes all of these deps.
38+
s.add_development_dependency 'rdf-n3'
39+
s.add_development_dependency 'rdf-rdfxml'
40+
s.add_development_dependency 'json-ld'
41+
3442
s.add_development_dependency 'pry'
3543
s.add_development_dependency 'pry-byebug'
3644
s.add_development_dependency 'rspec-rails'

spec/spec_helper.rb

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
require 'linkeddata'
1+
# Not sure why these RDF-related gems are only being used in CI and not general
2+
# dependencies... maybe meant to be optional dependencies?
3+
require 'rdf/n3'
4+
require 'rdf/rdfxml'
5+
require 'json/ld'
6+
27
require 'json'
38
require 'engine_cart'
49
require 'byebug' unless ENV['TRAVIS']

spec/test_app_templates/Gemfile.extra

-9
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,6 @@ group :development do
1111
#
1212
if ENV['RAILS_VERSION'] && Gem::Version.new(ENV['RAILS_VERSION']) < Gem::Version.new("6.1")
1313
gem 'psych', '< 4'
14-
15-
# Some versions of linkeddata dependency depend on yaml-ld gem... yaml-ld 0.0.1
16-
# has a dependency on psych 4.x specifically, conflicting with above, bundler
17-
# seems to be having trouble resolving to yaml-ld 0.0.2 on it's own.
18-
# We don't actually depend on yaml-ld at all ourselves, just trying
19-
# to help bundler resolve a tree that works.
20-
#
21-
# https://github.com/ruby-rdf/linkeddata/issues/16#issuecomment-1239912981
22-
gem 'yaml-ld', ">= 0.0.2"
2314
end
2415

2516
if ENV['RAILS_VERSION'] =~ /^6\.1\./ && ENV['RUBY_VERSION'] =~ /^3\.1\./

0 commit comments

Comments
 (0)