fix(domain): remove ds records option

Author: jremy42

docs/resources/domain_domains_registration.md renamed to docs/resources/domain_registration.md

@@ -1,11 +1,11 @@
 ---
 subcategory: "Domains and DNS"  
-page_title: "Scaleway: scaleway_domain_domains_registration"
+page_title: "Scaleway: scaleway_domain_registration"
 ---
 
-# Resource: scaleway_domain_domains_registration
+# Resource: scaleway_domain_registration
 
-The `scaleway_domain_domains_registration` resource allows you to purchase and manage domain registrations with Scaleway. Using this resource you can register one or more domains for a specified duration, configure auto-renewal and DNSSEC options, and set contact information. You can supply an owner contact either by providing an existing contact ID or by specifying the complete contact details. The resource automatically returns additional contact information (administrative and technical) as provided by the Scaleway API.
+The `scaleway_domain_registration` resource allows you to purchase and manage domain registrations with Scaleway. Using this resource you can register one or more domains for a specified duration, configure auto-renewal and DNSSEC options, and set contact information. You can supply an owner contact either by providing an existing contact ID or by specifying the complete contact details. The resource automatically returns additional contact information (administrative and technical) as provided by the Scaleway API.
 
 Refer to the [Domains and DNS documentation](https://www.scaleway.com/en/docs/network/domains-and-dns/) and the [API documentation](https://developers.scaleway.com/) for more details.
 
@@ -16,7 +16,7 @@ Refer to the [Domains and DNS documentation](https://www.scaleway.com/en/docs/ne
 The following example purchases a domain with a one-year registration period and specifies the owner contact details. Administrative and technical contacts are returned by the API.
 
 ```terraform
-resource "scaleway_domain_domains_registration" "test" {
+resource "scaleway_domain_registration" "test" {
   domain_names      = ["example.com"]
   duration_in_years = 1
 
@@ -41,7 +41,7 @@ resource "scaleway_domain_domains_registration" "test" {
 You can update the resource to enable auto-renewal and DNSSEC:
 
 ```terraform
-resource "scaleway_domain_domains_registration" "test" {
+resource "scaleway_domain_registration" "test" {
   domain_names      = ["example.com"]
   duration_in_years = 1
 
@@ -69,7 +69,7 @@ resource "scaleway_domain_domains_registration" "test" {
 The following example registers several domains in one go:
 
 ```terraform
-resource "scaleway_domain_domains_registration" "multi" {
+resource "scaleway_domain_registration" "multi" {
   domain_names      = ["domain1.com", "domain2.com", "domain3.com"]
   duration_in_years = 1
 
@@ -102,8 +102,6 @@ The following arguments are supported:
 - `technical_contact` (Computed, List): Technical contact information.
 - `auto_renew` (Optional, Boolean, Default: false): Enables or disables auto-renewal.
 - `dnssec` (Optional, Boolean, Default: false): Enables or disables DNSSEC.
-- `ds_record` (Optional, List): DNSSEC DS record configuration.
-- `is_external` (Optional, Boolean, Computed): Indicates whether Scaleway is the registrar.
 
 ## Attributes Reference
 
@@ -116,6 +114,10 @@ In addition to all arguments above, the following attributes are exported:
 - `registrar`: Name of the registrar.
 - `status`: Status of the domain registration.
 - `dns_zones`: List of DNS zones associated with the domain.
+- `ds_record`: DNSSEC DS record configuration.
+- `task_id`: ID of the task that created the domain.
+
+
 
 ## Contact Blocks
 
@@ -139,7 +141,7 @@ Each contact block supports the following attributes:
 To import an existing domain registration, use:
 
 ```bash
-terraform import scaleway_domain_domains_registration.test <project_id>/<task_id>
+terraform import scaleway_domain_registration.test <project_id>/<task_id>
 ```
 
 

internal/provider/provider.go

@@ -139,7 +139,7 @@ func Provider(config *Config) plugin.ProviderFunc {
 				"scaleway_container_token":                     container.ResourceToken(),
 				"scaleway_container_trigger":                   container.ResourceTrigger(),
 				"scaleway_domain_record":                       domain.ResourceRecord(),
-				"scaleway_domain_domains_registration":         domain.ResourceDomainsRegistration(),
+				"scaleway_domain_registration":                 domain.ResourceRegistration(),
 				"scaleway_domain_zone":                         domain.ResourceZone(),
 				"scaleway_flexible_ip":                         flexibleip.ResourceIP(),
 				"scaleway_flexible_ip_mac_address":             flexibleip.ResourceMACAddress(),

internal/services/domain/helpers.go

@@ -580,42 +580,6 @@ func waitForTaskCompletion(ctx context.Context, registrarAPI *domain.RegistrarAP
 	})
 }
 
-func ExpandDSRecord(dsRecordList []interface{}) *domain.DSRecord {
-	if len(dsRecordList) == 0 || dsRecordList[0] == nil {
-		return nil
-	}
-
-	dsRecordMap := dsRecordList[0].(map[string]interface{})
-	dsRecord := &domain.DSRecord{
-		KeyID:     uint32(dsRecordMap["key_id"].(int)),
-		Algorithm: domain.DSRecordAlgorithm(dsRecordMap["algorithm"].(string)),
-	}
-
-	if digestList, ok := dsRecordMap["digest"].([]interface{}); ok && len(digestList) > 0 {
-		digestMap := digestList[0].(map[string]interface{})
-		dsRecord.Digest = &domain.DSRecordDigest{
-			Type:   domain.DSRecordDigestType(digestMap["type"].(string)),
-			Digest: digestMap["digest"].(string),
-		}
-
-		if publicKeyList, ok := digestMap["public_key"].([]interface{}); ok && len(publicKeyList) > 0 {
-			publicKeyMap := publicKeyList[0].(map[string]interface{})
-			dsRecord.Digest.PublicKey = &domain.DSRecordPublicKey{
-				Key: publicKeyMap["key"].(string),
-			}
-		}
-	}
-
-	if publicKeyList, ok := dsRecordMap["public_key"].([]interface{}); ok && len(publicKeyList) > 0 {
-		publicKeyMap := publicKeyList[0].(map[string]interface{})
-		dsRecord.PublicKey = &domain.DSRecordPublicKey{
-			Key: publicKeyMap["key"].(string),
-		}
-	}
-
-	return dsRecord
-}
-
 func FlattenDSRecord(dsRecords []*domain.DSRecord) []interface{} {
 	if len(dsRecords) == 0 {
 		return []interface{}{}