feat(rdb): update cassette and fix test

Author: jremy42

internal/services/rdb/helpers.go

@@ -173,7 +173,6 @@ func expandInstanceLogsPolicy(i interface{}) *rdb.LogsPolicy {
 			TotalDiskRetention: expandSizePtr(policy["total_disk_retention"]),
 		}
 	}
-
 	return nil
 }
 

internal/services/rdb/instance.go

@@ -285,6 +285,7 @@ func ResourceInstance() *schema.Resource {
 			"logs_policy": {
 				Type:        schema.TypeList,
 				Optional:    true,
+				Computed:    true,
 				Description: "Logs policy configuration",
 				MaxItems:    1,
 				Elem: &schema.Resource{
@@ -293,11 +294,13 @@ func ResourceInstance() *schema.Resource {
 						"max_age_retention": {
 							Type:        schema.TypeInt,
 							Optional:    true,
+							Computed:    true,
 							Description: "The max age (in days) of remote logs to keep on the Database Instance",
 						},
 						"total_disk_retention": {
 							Type:        schema.TypeInt,
 							Optional:    true,
+							Computed:    true,
 							Description: "The max disk size of remote logs to keep on the Database Instance.",
 						},
 					},
@@ -378,7 +381,6 @@ func ResourceRdbInstanceCreate(ctx context.Context, d *schema.ResourceData, m in
 	// Configure Schedule Backup
 	// BackupScheduleFrequency and BackupScheduleRetention can only configure after instance creation
 	if !d.Get("disable_backup").(bool) {
-
 		updateReq.BackupSameRegion = types.ExpandBoolPtr(d.Get("backup_same_region"))
 		updateReq.IsBackupScheduleDisabled = scw.BoolPtr(d.Get("disable_backup").(bool))
 		if backupScheduleFrequency, okFrequency := d.GetOk("backup_schedule_frequency"); okFrequency {
@@ -683,7 +685,10 @@ func ResourceRdbInstanceUpdate(ctx context.Context, d *schema.ResourceData, m in
 	}
 
 	if d.HasChange("logs_policy") {
-		req.LogsPolicy = expandInstanceLogsPolicy(d.Get("logs_policy"))
+		policyRaw, exist := d.GetOk("logs_policy")
+		if exist {
+			req.LogsPolicy = expandInstanceLogsPolicy(policyRaw)
+		}
 	}
 
 	_, err = waitForRDBInstance(ctx, rdbAPI, region, ID, d.Timeout(schema.TimeoutUpdate))

internal/services/rdb/instance_test.go

@@ -144,8 +144,8 @@ func TestAccInstance_WithCluster(t *testing.T) {
 func TestAccInstance_LogsPolicy(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
-	latestEngineVersion := rdbchecks.GetLatestEngineVersion(tt, postgreSQLEngineName)
 
+	latestEngineVersion := rdbchecks.GetLatestEngineVersion(tt, postgreSQLEngineName)
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:          func() { acctest.PreCheck(t) },
 		ProviderFactories: tt.ProviderFactories,
@@ -186,14 +186,14 @@ func TestAccInstance_LogsPolicy(t *testing.T) {
 						password = "thiZ_is_v&ry_s8cret"
 						tags = [ "terraform-test", "scaleway_rdb_instance", "minimal" ]
   						logs_policy {
-							max_age_retention    = 30
-							total_disk_retention = 100000000
+							max_age_retention    = 10
+							total_disk_retention = 200000000
 					  }
 					}
 				`, latestEngineVersion),
 				Check: resource.ComposeTestCheckFunc(
 					isInstancePresent(tt, "scaleway_rdb_instance.main"),
-					resource.TestCheckResourceAttr("scaleway_rdb_instance.main", "logs_policy.0.max_age_retention", "30"),
+					resource.TestCheckResourceAttr("scaleway_rdb_instance.main", "logs_policy.0.max_age_retention", "10"),
 					resource.TestCheckResourceAttr("scaleway_rdb_instance.main", "logs_policy.0.total_disk_retention", "200000000"),
 				),
 			},