scx_lavd: Get the right CPU context from ops.stopping() #1732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similarly to commit e81fa0d ("lavd: get cpu context of scx_bpf_task_cpu in running") apply the same change to ops.stopping() as well. Both ops.running() and ops.stopping() can be called from a CPU other than the one the task is assigned to (i.e., a task changing a property of another task), therefore always rely on scx_bpf_task_cpu() to get the right CPU context. Signed-off-by: Andrea Righi <[email protected]>
hodgesds
approved these changes
Apr 23, 2025
|
Thanks @arighi for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to commit e81fa0d ("lavd: get cpu context of scx_bpf_task_cpu in running") apply the same change to ops.stopping() as well.
Both ops.running() and ops.stopping() can be called from a CPU other than the one the task is assigned to (i.e., a task changing a property of another task), therefore always rely on scx_bpf_task_cpu() to get the right CPU context.