Skip to content

scx_rustland_core: Move mandatory scheduler options to BPF #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

arighi
Copy link
Contributor

@arighi arighi commented Apr 29, 2025

SCX_OPS_KEEP_BUILTIN_IDLE and SCX_OPS_ENQ_LAST are strictly required for scx_rustland_core to function correctly. Without them, the framework may behave incorrectly, potentially leading to runtime errors or stalls.

To ensure these options are always defined, move them to BPF, instead of relying on the compat APIs. In this way, any missing definitions will result in a build-time error rather than runtime failures.

SCX_OPS_KEEP_BUILTIN_IDLE and SCX_OPS_ENQ_LAST are strictly required for
scx_rustland_core to function correctly. Without them, the framework may
behave incorrectly, potentially leading to runtime errors or stalls.

To ensure these options are always defined, move them to BPF, instead of
relying on the compat APIs. In this way, any missing definitions will
result in a build-time error rather than runtime failures.

Signed-off-by: Andrea Righi <[email protected]>
Copy link
Contributor

@JakeHillion JakeHillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@arighi arighi added this pull request to the merge queue Apr 29, 2025
Merged via the queue into main with commit 14a03db Apr 29, 2025
32 checks passed
@arighi arighi deleted the rustland-core-opts branch April 29, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants