Extract class

Author: sebastianbergmann

src/CodeCoverage.php

@@ -31,6 +31,7 @@
 use SebastianBergmann\CodeCoverage\Test\Target\MapBuilder;
 use SebastianBergmann\CodeCoverage\Test\Target\Mapper;
 use SebastianBergmann\CodeCoverage\Test\Target\TargetCollection;
+use SebastianBergmann\CodeCoverage\Test\Target\TargetCollectionValidator;
 use SebastianBergmann\CodeCoverage\Test\Target\ValidationResult;
 use SebastianBergmann\CodeCoverage\Test\TestSize\TestSize;
 use SebastianBergmann\CodeCoverage\Test\TestStatus\TestStatus;
@@ -368,7 +369,7 @@ public function detectsDeadCode(): bool
 
     public function validate(TargetCollection $targets): ValidationResult
     {
-        return $targets->validate($this->targetMapper());
+        return (new TargetCollectionValidator)->validate($this->targetMapper(), $targets);
     }
 
     /**

src/Target/TargetCollection.php

@@ -10,7 +10,6 @@
 namespace SebastianBergmann\CodeCoverage\Test\Target;
 
 use function count;
-use function implode;
 use Countable;
 use IteratorAggregate;
 
@@ -68,23 +67,4 @@ public function getIterator(): TargetCollectionIterator
     {
         return new TargetCollectionIterator($this);
     }
-
-    public function validate(Mapper $mapper): ValidationResult
-    {
-        $errors = [];
-
-        foreach ($this->targets as $target) {
-            try {
-                $mapper->mapTarget($target);
-            } catch (InvalidCodeCoverageTargetException $e) {
-                $errors[] = $e->getMessage();
-            }
-        }
-
-        if ($errors === []) {
-            return ValidationResult::success();
-        }
-
-        return ValidationResult::failure(implode("\n", $errors));
-    }
 }

src/Target/TargetCollectionValidator.php

@@ -0,0 +1,39 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of phpunit/php-code-coverage.
+ *
+ * (c) Sebastian Bergmann <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace SebastianBergmann\CodeCoverage\Test\Target;
+
+use function implode;
+
+/**
+ * @no-named-arguments Parameter names are not covered by the backward compatibility promise for phpunit/php-code-coverage
+ *
+ * @internal This class is not covered by the backward compatibility promise for phpunit/php-code-coverage
+ */
+final readonly class TargetCollectionValidator
+{
+    public function validate(Mapper $mapper, TargetCollection $targets): ValidationResult
+    {
+        $errors = [];
+
+        foreach ($targets as $target) {
+            try {
+                $mapper->mapTarget($target);
+            } catch (InvalidCodeCoverageTargetException $e) {
+                $errors[] = $e->getMessage();
+            }
+        }
+
+        if ($errors === []) {
+            return ValidationResult::success();
+        }
+
+        return ValidationResult::failure(implode("\n", $errors));
+    }
+}

tests/tests/Target/TargetCollectionValidatorTest.php

@@ -0,0 +1,77 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of phpunit/php-code-coverage.
+ *
+ * (c) Sebastian Bergmann <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace SebastianBergmann\CodeCoverage\Test\Target;
+
+use function assert;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\Small;
+use PHPUnit\Framework\TestCase;
+use SebastianBergmann\CodeCoverage\Filter;
+use SebastianBergmann\CodeCoverage\StaticAnalysis\ParsingFileAnalyser;
+use SebastianBergmann\CodeCoverage\TestFixture\Target\TargetClass;
+
+/**
+ * @phpstan-import-type TargetMap from Mapper
+ */
+#[CoversClass(TargetCollectionValidator::class)]
+#[Small]
+final class TargetCollectionValidatorTest extends TestCase
+{
+    public function test_TargetCollection_is_valid_when_all_targets_can_be_mapped(): void
+    {
+        $targets   = TargetCollection::fromArray([Target::forClass(TargetClass::class)]);
+        $mapper    = $this->mapper([__DIR__ . '/../../_files/Target/TargetClass.php']);
+        $validator = new TargetCollectionValidator;
+
+        $result = $validator->validate($mapper, $targets);
+
+        $this->assertTrue($result->isSuccess());
+    }
+
+    public function test_TargetCollection_is_invalid_when_target_cannot_be_mapped(): void
+    {
+        $targets   = TargetCollection::fromArray([Target::forClass(TargetClass::class)]);
+        $mapper    = $this->mapper([]);
+        $validator = new TargetCollectionValidator;
+
+        $result = $validator->validate($mapper, $targets);
+
+        $this->assertTrue($result->isFailure());
+
+        assert($result instanceof ValidationFailure);
+
+        $this->assertSame(
+            'Class SebastianBergmann\CodeCoverage\TestFixture\Target\TargetClass is not a valid target for code coverage',
+            $result->message(),
+        );
+    }
+
+    /**
+     * @param list<non-empty-string> $files
+     */
+    private function mapper(array $files): Mapper
+    {
+        return new Mapper($this->map($files));
+    }
+
+    /**
+     * @param list<non-empty-string> $files
+     *
+     * @return TargetMap
+     */
+    private function map(array $files): array
+    {
+        $filter = new Filter;
+
+        $filter->includeFiles($files);
+
+        return (new MapBuilder)->build($filter, new ParsingFileAnalyser(false, false));
+    }
+}