Use the javac --release flag to enforce API compatibility

This is better than just using the `source` and `target` flags since
it also ensures that we don't accidentally use symbols from the wrong
version of java.

Author: shs96c

.bazelrc

@@ -4,8 +4,7 @@ try-import .bazelrc.local
 build --java_toolchain=@bazel_tools//tools/jdk:toolchain_java11
 
 # We target java 8 by default
-build --javacopt="-source 8"
-build --javacopt="-target 8"
+build --javacopt="--release 8"
 
 # Require java dependencies to be used and first-order
 build --strict_java_deps=strict

java/buildtools/src/dev/selenium/tools/jar/BUILD.bazel

@@ -4,9 +4,7 @@ java_binary(
     name = "MergeJars",
     srcs = glob(["*.java"]),
     javacopts = [
-        "-source",
-        "11",
-        "-target",
+        "--release",
         "11",
     ],
     main_class = "dev.selenium.tools.jar.MergeJars",

java/buildtools/src/dev/selenium/tools/javadoc/BUILD.bazel

@@ -4,9 +4,7 @@ java_binary(
     name = "javadoc",
     srcs = glob(["*.java"]),
     javacopts = [
-        "-source",
-        "11",
-        "-target",
+        "--release",
         "11",
     ],
     main_class = "dev.selenium.tools.javadoc.JavadocJarMaker",

java/buildtools/src/dev/selenium/tools/maven/BUILD.bazel

@@ -5,9 +5,7 @@ java_binary(
     name = "MavenPublisher",
     srcs = ["MavenPublisher.java"],
     javacopts = [
-        "-source",
-        "11",
-        "-target",
+        "--release",
         "11",
     ],
     main_class = "dev.selenium.tools.maven.MavenPublisher",

java/buildtools/src/dev/selenium/tools/modules/BUILD.bazel

@@ -5,9 +5,7 @@ java_binary(
     name = "ModuleGenerator",
     srcs = glob(["*.java"]),
     javacopts = [
-        "-source",
-        "11",
-        "-target",
+        "--release",
         "11",
     ],
     main_class = "dev.selenium.tools.modules.ModuleGenerator",

java/client/test/org/openqa/selenium/environment/BUILD.bazel

@@ -36,9 +36,7 @@ java_library(
         "@com_google_javascript_closure_library",
     ],
     javacopts = [
-        "-source",
-        "11",
-        "-target",
+        "--release",
         "11",
     ],
     visibility = [

java/client/test/org/openqa/selenium/remote/http/BUILD.bazel

@@ -6,9 +6,7 @@ java_test_suite(
     size = "small",
     srcs = glob(["*.java"]),
     javacopts = [
-        "-source",
-        "11",
-        "-target",
+        "--release",
         "11",
     ],
     deps = [

java/client/test/org/openqa/selenium/tools/modules/BUILD.bazel

@@ -12,10 +12,8 @@ load("//java:defs.bzl", "java_test_suite")
 #        "with-module-info.jar",
 #    ],
 #    javacopts = [
-#        "-source",
-#        "9",
-#        "-target",
-#        "9",
+#        "--release",
+#        "11",
 #    ],
 #    deps = [
 #        "//java/buildtools/src/dev/selenium/tools/modules:ModuleGenerator",

java/server/test/org/openqa/selenium/grid/graphql/BUILD.bazel

@@ -6,9 +6,7 @@ java_test_suite(
     size = "small",
     srcs = glob(["*.java"]),
     javacopts = [
-        "-source",
-        "11",
-        "-target",
+        "--release",
         "11",
     ],
     deps = [