Skip to content

Commit 0eb85c7

Browse files
committed
[java] Reverting an assume that unintentionally disabled devtools tests in chrome and bumping min Firefox version for devtools tests to 87
1 parent 129028e commit 0eb85c7

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

java/client/test/org/openqa/selenium/devtools/DevToolsTestBase.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
package org.openqa.selenium.devtools;
1919

2020
import static org.assertj.core.api.Assumptions.assumeThat;
21-
import static org.openqa.selenium.testing.TestUtilities.isFirefoxVersionNotLessThan;
21+
import static org.openqa.selenium.testing.TestUtilities.isFirefoxVersionOlderThan;
2222

2323
import org.junit.Before;
2424
import org.openqa.selenium.testing.JUnit4TestBase;
@@ -30,7 +30,7 @@ public abstract class DevToolsTestBase extends JUnit4TestBase {
3030
@Before
3131
public void setUp() {
3232
assumeThat(driver).isInstanceOf(HasDevTools.class);
33-
assumeThat(isFirefoxVersionNotLessThan(83, driver)).isTrue();
33+
assumeThat(isFirefoxVersionOlderThan(87, driver)).isFalse();
3434

3535
devTools = ((HasDevTools) driver).getDevTools();
3636
devTools.createSessionIfThereIsNotOne();

java/client/test/org/openqa/selenium/support/devtools/NetworkInterceptorTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
import static org.assertj.core.api.Assumptions.assumeThat;
3939
import static org.openqa.selenium.remote.http.Contents.utf8String;
4040
import static org.openqa.selenium.testing.Safely.safelyCall;
41-
import static org.openqa.selenium.testing.TestUtilities.isFirefoxVersionNotLessThan;
41+
import static org.openqa.selenium.testing.TestUtilities.isFirefoxVersionOlderThan;
4242

4343
public class NetworkInterceptorTest {
4444

@@ -56,7 +56,7 @@ public void setup() {
5656
driver = new WebDriverBuilder().get();
5757

5858
assumeThat(driver).isInstanceOf(HasDevTools.class);
59-
assumeThat(isFirefoxVersionNotLessThan(83, driver)).isTrue();
59+
assumeThat(isFirefoxVersionOlderThan(87, driver)).isFalse();
6060

6161
appServer = new NettyAppServer(req -> new HttpResponse()
6262
.setStatus(200)

java/client/test/org/openqa/selenium/testing/TestUtilities.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ public static boolean isFirefox(WebDriver driver) {
6060
return getUserAgent(driver).contains("Firefox");
6161
}
6262

63-
public static boolean isFirefoxVersionNotLessThan(int version, WebDriver driver) {
64-
return isFirefox(driver) && getFirefoxVersion(driver) >= version;
63+
public static boolean isFirefoxVersionOlderThan(int version, WebDriver driver) {
64+
return isFirefox(driver) && getFirefoxVersion(driver) < version;
6565
}
6666

6767
public static boolean isInternetExplorer(WebDriver driver) {

0 commit comments

Comments
 (0)