Skip to content

Commit 218c142

Browse files
committed
[java] Disabling some Chrome tests that were failing on travis and fail now on GitHub Actions too
1 parent 83582f8 commit 218c142

File tree

5 files changed

+15
-8
lines changed

5 files changed

+15
-8
lines changed

java/client/test/org/openqa/selenium/SlowLoadingPageTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public void testShouldBlockUntilIFramesAreLoaded() {
4545
}
4646

4747
@Test
48-
@Ignore(value = CHROME, travis = true)
48+
@Ignore(value = CHROME, travis = true, gitHubActions = true)
4949
@Ignore(value = CHROMIUMEDGE)
5050
public void testRefreshShouldBlockUntilPageLoads() {
5151
long start = System.currentTimeMillis();

java/client/test/org/openqa/selenium/WindowTest.java

+7-6
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import static org.assertj.core.api.Assertions.assertThat;
2121
import static org.junit.Assume.assumeFalse;
2222
import static org.openqa.selenium.Platform.ANDROID;
23+
import static org.openqa.selenium.testing.drivers.Browser.CHROME;
2324
import static org.openqa.selenium.testing.drivers.Browser.EDGE;
2425
import static org.openqa.selenium.testing.drivers.Browser.SAFARI;
2526

@@ -118,7 +119,7 @@ public void testSetsThePositionOfTheCurrentWindow() {
118119
}
119120

120121
@Test
121-
@Ignore(travis = true)
122+
@Ignore(value = CHROME, travis = true, gitHubActions = true)
122123
@Ignore(EDGE)
123124
public void testCanMaximizeTheWindow() {
124125
// Browser window cannot be resized or moved on ANDROID (and most mobile platforms
@@ -131,7 +132,7 @@ public void testCanMaximizeTheWindow() {
131132

132133
@SwitchToTopAfterTest
133134
@Test
134-
@Ignore(travis = true)
135+
@Ignore(value = CHROME, travis = true, gitHubActions = true)
135136
@Ignore(EDGE)
136137
public void testCanMaximizeTheWindowFromFrame() {
137138
// Browser window cannot be resized or moved on ANDROID (and most mobile platforms
@@ -147,7 +148,7 @@ public void testCanMaximizeTheWindowFromFrame() {
147148

148149
@SwitchToTopAfterTest
149150
@Test
150-
@Ignore(travis = true)
151+
@Ignore(value = CHROME, travis = true, gitHubActions = true)
151152
@Ignore(EDGE)
152153
public void testCanMaximizeTheWindowFromIframe() {
153154
// Browser window cannot be resized or moved on ANDROID (and most mobile platforms
@@ -174,7 +175,7 @@ public void canMinimizeTheWindow() {
174175
}
175176

176177
@Test
177-
@Ignore(travis = true)
178+
@Ignore(value = CHROME, travis = true, gitHubActions = true)
178179
@Ignore(SAFARI)
179180
@Ignore(EDGE)
180181
public void canFullscreenTheWindow() {
@@ -188,7 +189,7 @@ public void canFullscreenTheWindow() {
188189

189190
@SwitchToTopAfterTest
190191
@Test
191-
@Ignore(travis = true)
192+
@Ignore(value = CHROME, travis = true, gitHubActions = true)
192193
@Ignore(SAFARI)
193194
@Ignore(EDGE)
194195
public void canFullscreenTheWindowFromFrame() {
@@ -205,7 +206,7 @@ public void canFullscreenTheWindowFromFrame() {
205206

206207
@SwitchToTopAfterTest
207208
@Test
208-
@Ignore(travis = true)
209+
@Ignore(value = CHROME, travis = true, gitHubActions = true)
209210
@Ignore(SAFARI)
210211
@Ignore(EDGE)
211212
public void canFullscreenTheWindowFromIframe() {

java/client/test/org/openqa/selenium/testing/Ignore.java

+2
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,6 @@
3737
String issue() default "";
3838

3939
boolean travis() default false;
40+
41+
boolean gitHubActions() default false;
4042
}

java/client/test/org/openqa/selenium/testing/IgnoreComparator.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
import org.eclipse.egit.github.core.Issue;
2121
import org.eclipse.egit.github.core.service.IssueService;
22-
import org.openqa.selenium.Platform;
2322
import org.openqa.selenium.testing.drivers.Browser;
2423

2524
import java.io.IOException;
@@ -50,6 +49,7 @@ private boolean shouldIgnore(Stream<Ignore> ignoreList) {
5049
return ignoreList.anyMatch(driver ->
5150
(ignored.contains(driver.value()) || driver.value() == Browser.ALL)
5251
&& (!driver.travis() || TestUtilities.isOnTravis())
52+
&& (!driver.gitHubActions() || TestUtilities.isOnTravis())
5353
&& isOpen(driver.issue()));
5454
}
5555

java/client/test/org/openqa/selenium/testing/TestUtilities.java

+4
Original file line numberDiff line numberDiff line change
@@ -174,4 +174,8 @@ public static boolean isLocal() {
174174
public static boolean isOnTravis() {
175175
return Boolean.parseBoolean(System.getenv("TRAVIS"));
176176
}
177+
178+
public static boolean isOnGitHubActions() {
179+
return Boolean.parseBoolean(System.getenv("GITHUB_ACTIONS"));
180+
}
177181
}

0 commit comments

Comments
 (0)