Allow dmg values to be extracted to custom locations

Author: shs96c

common/private/convert_dmg.sh

@@ -18,12 +18,16 @@
 
 DMGFILE=$1
 OUTFILE=$2
+
+echo $OUTFILE
+
 mkdir -p tmp
-VOLUME=$(hdiutil attach "${DMGFILE}" | tail -1 | awk '{print $3}')
-cp -r "${VOLUME}/"*.app tmp
+VOLUME="$(hdiutil attach "${DMGFILE}" | tail -1 | awk -F'\t' '{print $NF}')"
+CWD="`pwd`"
+echo ${VOLUME}
+cd "${VOLUME}"
+zip -r /tmp/firefox.zip *.app
+cd "${CWD}"
 hdiutil detach "${VOLUME}" >/dev/null
-cd tmp
-zip -r "../${OUTFILE}" *
-cd ..
-rm -rf tmp
-rm "${DMGFILE}"
+#rm "${DMGFILE}"
+mv /tmp/firefox.zip "$OUTFILE"

common/private/dmg_archive.bzl

@@ -24,6 +24,7 @@ def _dmg_archive_impl(repository_ctx):
     repository_ctx.extract(
         archive = zip_name,
         stripPrefix = repository_ctx.attr.strip_prefix,
+        output = repository_ctx.attr.output,
     )
 
     repository_ctx.file(
@@ -39,6 +40,7 @@ dmg_archive = repository_rule(
         ),
         "sha256": attr.string(),
         "strip_prefix": attr.string(),
+        "output": attr.string(),
         "build_file_content": attr.string(),
         "build_file": attr.label(),
     },