Skip to content

Commit 4d0cc24

Browse files
committed
[java] Using annotations to start Chrome headless for PrintPageTest
No ideal solution but this should at least make tests pass and leave a green CI
1 parent 79d57fa commit 4d0cc24

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

java/client/test/org/openqa/selenium/PrintPageTest.java

+17-1
Original file line numberDiff line numberDiff line change
@@ -20,24 +20,36 @@
2020
import static org.assertj.core.api.Assertions.assertThat;
2121
import static org.junit.Assume.assumeTrue;
2222

23+
import org.junit.After;
2324
import org.junit.Before;
2425
import org.junit.Test;
2526
import org.openqa.selenium.print.PageSize;
2627
import org.openqa.selenium.print.PrintOptions;
2728
import org.openqa.selenium.testing.JUnit4TestBase;
29+
import org.openqa.selenium.testing.NoDriverAfterTest;
30+
import org.openqa.selenium.testing.NoDriverBeforeTest;
2831

2932
public class PrintPageTest extends JUnit4TestBase {
3033
private static final String MAGIC_STRING = "JVBER";
3134
private PrintsPage printer;
3235

3336
@Before
3437
public void setUp() {
38+
System.setProperty("webdriver.chrome.headless", "true");
39+
createNewDriver(new ImmutableCapabilities());
3540
assumeTrue(driver instanceof PrintsPage);
3641
printer = (PrintsPage) driver;
3742
driver.get(pages.printPage);
3843
}
3944

45+
@After
46+
public void tearDown() {
47+
System.clearProperty("webdriver.chrome.headless");
48+
}
49+
4050
@Test
51+
@NoDriverBeforeTest
52+
@NoDriverAfterTest
4153
public void canPrintPage() {
4254
PrintOptions printOptions = new PrintOptions();
4355

@@ -46,7 +58,9 @@ public void canPrintPage() {
4658
}
4759

4860
@Test
49-
public void canPrintwoPages() {
61+
@NoDriverBeforeTest
62+
@NoDriverAfterTest
63+
public void canPrintTwoPages() {
5064
PrintOptions printOptions = new PrintOptions();
5165
printOptions.setPageRanges("1-2");
5266

@@ -55,6 +69,8 @@ public void canPrintwoPages() {
5569
}
5670

5771
@Test
72+
@NoDriverBeforeTest
73+
@NoDriverAfterTest
5874
public void canPrintWithValidParams() {
5975
PrintOptions printOptions = new PrintOptions();
6076
PageSize pageSize = new PageSize();

java/client/test/org/openqa/selenium/testing/drivers/WebDriverBuilder.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ static void addShutdownAction(Runnable action) {
6161

6262
private static final Map<Browser, Function<Capabilities, Capabilities>> capabilitySuppliers =
6363
new ImmutableMap.Builder<Browser, Function<Capabilities, Capabilities>>()
64-
.put(Browser.CHROME, original -> new ChromeOptions().merge(original))
64+
.put(Browser.CHROME, original -> new ChromeOptions().merge(original)
65+
.setHeadless(Boolean.getBoolean("webdriver.chrome.headless"))
66+
)
6567
.put(Browser.LEGACY_FIREFOX_XPI, original -> new FirefoxOptions(original)
6668
.setHeadless(Boolean.parseBoolean(System.getProperty("webdriver.firefox.headless", "false"))))
6769
.put(Browser.FIREFOX, original -> new FirefoxOptions(original)

0 commit comments

Comments
 (0)