Skip to content

Commit 7358b15

Browse files
committed
[java] Fixing use of deprecated classes and methods after upgrading opentelemetry
1 parent 0250d66 commit 7358b15

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

java/client/src/org/openqa/selenium/remote/tracing/AttributeKey.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
package org.openqa.selenium.remote.tracing;
1919

20-
import io.opentelemetry.api.trace.attributes.SemanticAttributes;
20+
import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
2121

2222
public enum AttributeKey {
2323

java/server/src/org/openqa/selenium/grid/log/LoggingOptions.java

+5-4
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
import io.opentelemetry.api.GlobalOpenTelemetry;
2121
import io.opentelemetry.api.common.Attributes;
22+
import io.opentelemetry.api.trace.StatusCode;
2223
import io.opentelemetry.api.trace.propagation.W3CTraceContextPropagator;
2324
import io.opentelemetry.context.propagation.ContextPropagators;
2425
import io.opentelemetry.context.propagation.TextMapPropagator;
@@ -128,7 +129,7 @@ private Tracer createTracer() {
128129
LOG.info("Using OpenTelemetry for tracing");
129130
SdkTracerManagement tracerManagement = OpenTelemetrySdk.getGlobalTracerManagement();
130131
List<SpanProcessor> exporters = new LinkedList<>();
131-
exporters.add(SimpleSpanProcessor.builder(new SpanExporter() {
132+
exporters.add(SimpleSpanProcessor.create(new SpanExporter() {
132133
@Override
133134
public CompletableResultCode export(Collection<SpanData> spans) {
134135

@@ -154,7 +155,7 @@ public CompletableResultCode export(Collection<SpanData> spans) {
154155
(attributeKey, value) -> attributeMap.put(attributeKey.getKey(), value));
155156
map.put("attributes", attributeMap);
156157
String jsonString = getJsonString(map);
157-
if (status.isOk()) {
158+
if (status.getStatusCode() == StatusCode.OK) {
158159
LOG.log(Level.FINE, jsonString);
159160
} else {
160161
LOG.log(Level.WARNING, jsonString);
@@ -174,14 +175,14 @@ public CompletableResultCode shutdown() {
174175
// no-op
175176
return CompletableResultCode.ofSuccess();
176177
}
177-
}).build());
178+
}));
178179

179180
// The Jaeger exporter doesn't yet have a `TracerFactoryProvider`, so we
180181
// shall look up the class using reflection, and beg for forgiveness
181182
// later.
182183
Optional<SpanExporter> maybeJaeger = JaegerTracing.findJaegerExporter();
183184
maybeJaeger.ifPresent(
184-
exporter -> exporters.add(SimpleSpanProcessor.builder(exporter).build()));
185+
exporter -> exporters.add(SimpleSpanProcessor.create(exporter)));
185186
tracerManagement.addSpanProcessor(SpanProcessor.composite(exporters));
186187

187188
// OpenTelemetry default propagators are no-op since version 0.9.0.

0 commit comments

Comments
 (0)