Skip to content

Commit 8c03b6d

Browse files
committed
[java] improving removeHeader to be case insensitive
1 parent 2743584 commit 8c03b6d

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

java/client/src/org/openqa/selenium/remote/http/HttpMessage.java

+10-7
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,6 @@
1717

1818
package org.openqa.selenium.remote.http;
1919

20-
import static com.google.common.net.HttpHeaders.CONTENT_TYPE;
21-
import static java.nio.charset.StandardCharsets.UTF_8;
22-
import static org.openqa.selenium.remote.http.Contents.bytes;
23-
import static org.openqa.selenium.remote.http.Contents.reader;
24-
import static org.openqa.selenium.remote.http.Contents.string;
25-
2620
import com.google.common.collect.ArrayListMultimap;
2721
import com.google.common.collect.ImmutableSet;
2822
import com.google.common.collect.Multimap;
@@ -40,6 +34,12 @@
4034
import java.util.function.Supplier;
4135
import java.util.stream.Collectors;
4236

37+
import static com.google.common.net.HttpHeaders.CONTENT_TYPE;
38+
import static java.nio.charset.StandardCharsets.UTF_8;
39+
import static org.openqa.selenium.remote.http.Contents.bytes;
40+
import static org.openqa.selenium.remote.http.Contents.reader;
41+
import static org.openqa.selenium.remote.http.Contents.string;
42+
4343
abstract class HttpMessage<M extends HttpMessage<M>> {
4444

4545
private final Multimap<String, String> headers = ArrayListMultimap.create();
@@ -106,7 +106,10 @@ public M addHeader(String name, String value) {
106106
}
107107

108108
public M removeHeader(String name) {
109-
headers.removeAll(name);
109+
String toRemove = headers.keySet().stream()
110+
.filter(header -> header.equalsIgnoreCase(name))
111+
.findFirst().orElse(name);
112+
headers.removeAll(toRemove);
110113
return self();
111114
}
112115

0 commit comments

Comments
 (0)