Skip to content

Commit 937e8f9

Browse files
committed
[java] Fixing test ignorance checker for GitHub Actions
1 parent 0ac86da commit 937e8f9

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

java/client/test/org/openqa/selenium/testing/IgnoreComparator.java

+6-6
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import java.util.stream.Stream;
3030

3131
public class IgnoreComparator {
32-
private Set<Browser> ignored = new HashSet<>();
32+
private final Set<Browser> ignored = new HashSet<>();
3333

3434
// TODO(simon): reduce visibility
3535
public void addDriver(Browser driverToIgnore) {
@@ -46,11 +46,11 @@ public boolean shouldIgnore(Ignore ignore) {
4646
}
4747

4848
private boolean shouldIgnore(Stream<Ignore> ignoreList) {
49-
return ignoreList.anyMatch(driver ->
50-
(ignored.contains(driver.value()) || driver.value() == Browser.ALL)
51-
&& (!driver.travis() || TestUtilities.isOnTravis())
52-
&& (!driver.gitHubActions() || TestUtilities.isOnTravis())
53-
&& isOpen(driver.issue()));
49+
return ignoreList.anyMatch(
50+
driver -> (ignored.contains(driver.value()) || driver.value() == Browser.ALL)
51+
&& (!driver.travis() || TestUtilities.isOnTravis())
52+
&& (!driver.gitHubActions() || TestUtilities.isOnGitHubActions())
53+
&& isOpen(driver.issue()));
5454
}
5555

5656
private boolean isOpen(String issue) {

0 commit comments

Comments
 (0)