Skip to content

Commit a787ad4

Browse files
committed
[grid] Making NewSessionCreationTest aware of the improvements on AddWebDriverSpecHeaders
1 parent 45567af commit a787ad4

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

java/client/src/org/openqa/selenium/remote/AddWebDriverSpecHeaders.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import org.openqa.selenium.json.Json;
2121
import org.openqa.selenium.remote.http.Filter;
2222
import org.openqa.selenium.remote.http.HttpHandler;
23-
import org.openqa.selenium.remote.http.HttpResponse;
2423

2524
public class AddWebDriverSpecHeaders implements Filter {
2625
@Override

java/server/test/org/openqa/selenium/grid/router/NewSessionCreationTest.java

+6-11
Original file line numberDiff line numberDiff line change
@@ -137,23 +137,18 @@ public void ensureJsCannotCreateANewSession() throws URISyntaxException {
137137
uri,
138138
uri,
139139
registrationSecret)
140-
.add(Browser.detect().getCapabilities(), new TestSessionFactory((id, caps) -> new Session(id, uri, Browser.detect().getCapabilities(), caps, Instant.now())))
140+
.add(
141+
Browser.detect().getCapabilities(),
142+
new TestSessionFactory(
143+
(id, caps) ->
144+
new Session(id, uri, Browser.detect().getCapabilities(), caps, Instant.now())))
141145
.build();
142146
distributor.add(node);
143147

144148
HttpClient client = HttpClient.Factory.createDefault().createClient(server.getUrl());
145149

146-
// Attempt to create a session without setting the content type
147-
HttpResponse res = client.execute(
148-
new HttpRequest(POST, "/session")
149-
.setContent(Contents.asJson(ImmutableMap.of(
150-
"capabilities", ImmutableMap.of(
151-
"alwaysMatch", Browser.detect().getCapabilities())))));
152-
153-
assertThat(res.getStatus()).isEqualTo(HTTP_INTERNAL_ERROR);
154-
155150
// Attempt to create a session with an origin header but content type set
156-
res = client.execute(
151+
HttpResponse res = client.execute(
157152
new HttpRequest(POST, "/session")
158153
.addHeader("Content-Type", JSON_UTF_8)
159154
.addHeader("Origin", "localhost")

0 commit comments

Comments
 (0)