Skip to content

Commit b0b8382

Browse files
committed
[cdp] Include supported CDP versions in the Grid
1 parent d1b21d0 commit b0b8382

File tree

3 files changed

+15
-14
lines changed

3 files changed

+15
-14
lines changed

java/client/src/org/openqa/selenium/BUILD.bazel

+2-10
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
load("//java:version.bzl", "SE_VERSION")
22
load("//java:defs.bzl", "java_dist_zip", "java_export", "java_import", "java_library", "javadoc")
3-
4-
CDP_VERSIONS = [
5-
"v86",
6-
"v87",
7-
"v88",
8-
"v89",
9-
]
3+
load("//java/client/src/org/openqa/selenium/devtools:versions.bzl", "CDP_DEPS")
104

115
filegroup(
126
name = "template-pom",
@@ -31,10 +25,10 @@ java_export(
3125
"org.openqa.selenium.interactions.internal",
3226
"org.openqa.selenium.internal",
3327
],
28+
maven_coordinates = "org.seleniumhq.selenium:selenium-api:%s" % SE_VERSION,
3429
opens_to = [
3530
"org.openqa.selenium.json",
3631
],
37-
maven_coordinates = "org.seleniumhq.selenium:selenium-api:%s" % SE_VERSION,
3832
pom_template = ":template-pom",
3933
visibility = ["//visibility:public"],
4034
deps = [
@@ -43,8 +37,6 @@ java_export(
4337
],
4438
)
4539

46-
CDP_DEPS = ["//java/client/src/org/openqa/selenium/devtools/%s" % v for v in CDP_VERSIONS]
47-
4840
java_export(
4941
name = "client-combined",
5042
maven_coordinates = "org.seleniumhq.selenium:selenium-java:" + SE_VERSION,
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
CDP_VERSIONS = [
2+
"v86",
3+
"v87",
4+
"v88",
5+
"v89",
6+
]
7+
8+
CDP_DEPS = ["//java/client/src/org/openqa/selenium/devtools/%s" % v for v in CDP_VERSIONS]

java/server/src/org/openqa/selenium/grid/BUILD.bazel

+5-4
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ load("@rules_jvm_external//:defs.bzl", "artifact")
22
load("//common:defs.bzl", "copy_file")
33
load("//java:defs.bzl", "java_binary", "java_dist_zip", "java_export", "java_library", "javadoc")
44
load("//java:version.bzl", "SE_VERSION")
5+
load("//java/client/src/org/openqa/selenium/devtools:versions.bzl", "CDP_DEPS")
56

67
genrule(
78
name = "executable-grid",
@@ -49,6 +50,9 @@ java_export(
4950
exclude = BASE_COMMAND_SRCS,
5051
),
5152
maven_coordinates = "org.seleniumhq.selenium:selenium-grid:%s" % SE_VERSION,
53+
opens_to = [
54+
"org.openqa.selenium.json",
55+
],
5256
pom_template = "//java/client/src/org/openqa/selenium:template-pom",
5357
resource_jars = [
5458
"//javascript/grid-ui:react_jar",
@@ -60,9 +64,6 @@ java_export(
6064
"org.openqa.selenium.remote.locators.CustomLocator",
6165
"org.openqa.selenium.remote.service.DriverService$Builder",
6266
],
63-
opens_to = [
64-
"org.openqa.selenium.json",
65-
],
6667
visibility = [
6768
"//visibility:public",
6869
],
@@ -81,7 +82,7 @@ java_export(
8182
"//java/server/src/org/openqa/selenium/grid/router/httpd",
8283
"//java/server/src/org/openqa/selenium/grid/sessionmap/httpd",
8384
"//java/server/src/org/openqa/selenium/grid/sessionqueue/httpd",
84-
],
85+
] + CDP_DEPS,
8586
deps = [
8687
":base-command",
8788
"//java/server/src/org/openqa/selenium/cli",

0 commit comments

Comments
 (0)