[py] Fix Flake 8 Errors

Author: AutomatedTester

py/generate.py

@@ -23,6 +23,8 @@
 # This is a copy of https://github.com/HyperionGray/python-chrome-devtools-protocol/blob/master/generator/generate.py
 # The license above is theirs and MUST be preserved.
 
+# flake8: noqa
+
 import builtins
 from dataclasses import dataclass
 from enum import Enum

py/selenium/webdriver/firefox/options.py

@@ -132,7 +132,7 @@ def headless(self, value):
         Args:
           value: boolean value indicating to set the headless option
         """
-        if value: # is True or == True can be written as bool(variablename), so 
+        if value:
             self._arguments.append('-headless')
         elif '-headless' in self._arguments:
             self._arguments.remove('-headless')

py/selenium/webdriver/firefox/service.py

@@ -41,7 +41,6 @@ def __init__(self, executable_path, port=0, service_args=None,
             in the services' environment.
 
         """
-        #the condition will fail on both "" and on None, so no need of `log_path is not None and log_path != ""`
         log_file = open(log_path, "a+") if log_path else None
 
         service.Service.__init__(

py/selenium/webdriver/remote/errorhandler.py

@@ -99,6 +99,7 @@ class ErrorHandler(object):
     """
     Handles errors returned by the WebDriver server.
     """
+
     def check_response(self, response):
         """
         Checks that a JSON response from the WebDriver does not have an error.
@@ -198,7 +199,7 @@ def check_response(self, response):
             exception_class = UnknownMethodException
         else:
             exception_class = WebDriverException
-        if not value: #if value == '' or value == None, the condition will be executed
+        if not value:
             value = response['value']
         if isinstance(value, basestring):
             raise exception_class(value)

py/selenium/webdriver/support/expected_conditions.py

@@ -80,7 +80,7 @@ def url_matches(pattern):
     pattern is the expected pattern, which must be an exact match
     returns True if the url matches, false otherwise."""
     def _predicate(driver):
-        return bool(re.search(pattern, driver.current_url)) #note bool is necessary
+        return bool(re.search(pattern, driver.current_url))
 
     return _predicate
 

py/selenium/webdriver/webkitgtk/service.py

@@ -32,7 +32,6 @@ def __init__(self, executable_path, port=0, log_path=None):
          - port : Port the service is running on
          - log_path : Path for the WebKitGTKDriver service to log to
         """
-        #the condition will fail on both "" and on None, so no need of `log_path is not None and log_path != ""`
         log_file = open(log_path, "wb") if log_path else None
         service.Service.__init__(self, executable_path, port, log_file)
 

py/selenium/webdriver/wpewebkit/service.py

@@ -32,7 +32,6 @@ def __init__(self, executable_path, port=0, log_path=None):
          - port : Port the service is running on
          - log_path : Path for the WPEWebKitDriver service to log to
         """
-        #the condition will fail on both "" and on None, so no need of `log_path is not None and log_path != ""`
         log_file = open(log_path, "wb") if log_path else None
         service.Service.__init__(self, executable_path, port, log_file)
 

py/test/unit/selenium/webdriver/common/print_page_options_tests.py

@@ -19,73 +19,91 @@
 
 from selenium.webdriver.common.print_page_options import PrintOptions
 
+
 @pytest.fixture
 def print_options():
     return PrintOptions()
 
+
 def test_set_orientation(print_options):
     print_options.orientation = 'portrait'
     assert print_options.orientation == 'portrait'
 
+
 def test_raises_exception_if_orientation_is_invalid(print_options):
     with pytest.raises(ValueError):
         print_options.orientation = 'foobar'
 
+
 def test_set_scale(print_options):
     print_options.scale = 1
     assert print_options.scale == 1
 
+
 def test_raises_exception_if_scale_is_outside_range(print_options):
     with pytest.raises(ValueError):
         print_options.scale = 3
 
+
 def test_raises_exception_if_scale_is_not_an_integer(print_options):
     with pytest.raises(ValueError):
         print_options.scale = "1"
 
+
 def test_set_background(print_options):
     print_options.background = True
     assert print_options.background is True
 
+
 def test_unset_value_to_be_none(print_options):
     assert print_options.page_width is None
 
+
 def test_set_width(print_options):
     print_options.page_width = 3
     assert print_options.page_width == 3
 
+
 def test_raises_exception_if_set_invalid_width(print_options):
     with pytest.raises(ValueError):
         print_options.page_width = -1
 
+
 def test_raises_exception_if_set_with_not_int(print_options):
     with pytest.raises(ValueError):
         print_options.page_width = "2"
 
+
 def test_set_height(print_options):
     print_options.page_height = 2
     assert print_options.page_height == 2
 
+
 def test_set_shrink_to_fit(print_options):
     print_options.shrink_to_fit = True
     assert print_options.shrink_to_fit is True
 
+
 def test_raises_exception_if_set_shrink_to_fit_non_bool(print_options):
     with pytest.raises(ValueError):
         print_options.shrink_to_fit = 'True'
 
+
 def test_set_page_ranges(print_options):
     print_options.page_ranges = ['1-2']
     assert print_options.page_ranges == ['1-2']
 
+
 def test_raises_exception_if_page_ranges_not_list(print_options):
     with pytest.raises(ValueError):
         print_options.page_ranges = 'foobar'
 
+
 def test_margin_height(print_options):
     print_options.margin_top = 2
     assert print_options.margin_top == 2
 
+
 def test_raises_exception_if_margin_is_invalid(print_options):
     with pytest.raises(ValueError):
         print_options.margin_top = -1