File tree 2 files changed +13
-9
lines changed
selenium/webdriver/remote
test/selenium/webdriver/common
2 files changed +13
-9
lines changed Original file line number Diff line number Diff line change @@ -1527,13 +1527,17 @@ async def add_listener(self, event_type):
1527
1527
await session .execute (devtools .runtime .enable ())
1528
1528
console = {
1529
1529
"message" : None ,
1530
+ "level" : None
1530
1531
}
1531
1532
async with session .wait_for (devtools .runtime .ConsoleAPICalled ) as messages :
1532
1533
yield console
1533
1534
1535
+ if event_type == Console .ERROR :
1536
+ console ["message" ] = messages .value .args [0 ].value
1537
+ console ["level" ] = messages .value .args [0 ].type_
1534
1538
if event_type == Console .ALL :
1535
1539
console ["message" ] = messages .value .args [0 ].value
1536
- # console["level"] = messages.value.message.level
1540
+ console ["level" ] = messages .value .args [ 0 ]. type_
1537
1541
1538
1542
@asynccontextmanager
1539
1543
async def _get_bidi_connection (self ):
Original file line number Diff line number Diff line change @@ -28,14 +28,14 @@ async def test_check_console_messages(driver, pages):
28
28
assert messages ["message" ] == "I love cheese"
29
29
30
30
31
- # Disabling for now after moving to Runtime APIs for console messages
32
- # async def test_check_error_console_messages(driver, pages):
33
- # pages.load("javascriptPage.html")
34
- # from selenium.webdriver.common.bidi.console import Console
35
- # async with driver.add_listener(Console.ERROR) as messages:
36
- # driver.execute_script("console.error(\"I don't cheese\" )")
37
- # driver.execute_script("console.log('I love cheese')")
38
- # assert messages["message"] == "I don't cheese"
31
+ async def test_check_error_console_messages ( driver , pages ):
32
+ pages . load ( "javascriptPage.html" )
33
+ from selenium . webdriver . common . bidi . console import Console
34
+ async with driver . add_listener ( Console . ERROR ) as messages :
35
+ driver .execute_script ( "console.error( \" I don't cheese \" )" )
36
+ driver .execute_script ("console.log('I love cheese' )" )
37
+ assert messages [ "message" ] == "I don't cheese"
38
+
39
39
40
40
@pytest .mark .xfail_firefox
41
41
@pytest .mark .xfail_safari
You can’t perform that action at this time.
0 commit comments