Skip to content

Commit b1f8773

Browse files
[py] Re-enabling console differentiation when listening for console logs
1 parent 691de4f commit b1f8773

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

py/selenium/webdriver/remote/webdriver.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -1527,13 +1527,17 @@ async def add_listener(self, event_type):
15271527
await session.execute(devtools.runtime.enable())
15281528
console = {
15291529
"message": None,
1530+
"level": None
15301531
}
15311532
async with session.wait_for(devtools.runtime.ConsoleAPICalled) as messages:
15321533
yield console
15331534

1535+
if event_type == Console.ERROR:
1536+
console["message"] = messages.value.args[0].value
1537+
console["level"] = messages.value.args[0].type_
15341538
if event_type == Console.ALL:
15351539
console["message"] = messages.value.args[0].value
1536-
# console["level"] = messages.value.message.level
1540+
console["level"] = messages.value.args[0].type_
15371541

15381542
@asynccontextmanager
15391543
async def _get_bidi_connection(self):

py/test/selenium/webdriver/common/bidi_tests.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@ async def test_check_console_messages(driver, pages):
2828
assert messages["message"] == "I love cheese"
2929

3030

31-
# Disabling for now after moving to Runtime APIs for console messages
32-
# async def test_check_error_console_messages(driver, pages):
33-
# pages.load("javascriptPage.html")
34-
# from selenium.webdriver.common.bidi.console import Console
35-
# async with driver.add_listener(Console.ERROR) as messages:
36-
# driver.execute_script("console.error(\"I don't cheese\")")
37-
# driver.execute_script("console.log('I love cheese')")
38-
# assert messages["message"] == "I don't cheese"
31+
async def test_check_error_console_messages(driver, pages):
32+
pages.load("javascriptPage.html")
33+
from selenium.webdriver.common.bidi.console import Console
34+
async with driver.add_listener(Console.ERROR) as messages:
35+
driver.execute_script("console.error(\"I don't cheese\")")
36+
driver.execute_script("console.log('I love cheese')")
37+
assert messages["message"] == "I don't cheese"
38+
3939

4040
@pytest.mark.xfail_firefox
4141
@pytest.mark.xfail_safari

0 commit comments

Comments
 (0)