Skip to content

Commit dbd00ca

Browse files
committed
Updating .NET DevTools tests to use Chrome 87 version of CDP
1 parent 4d44b47 commit dbd00ca

7 files changed

+134
-134
lines changed

dotnet/test/common/DevTools/DevToolsConsoleTest.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ public class DevToolsConsoleTest : DevToolsTestFixture
1919
[IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
2020
public async Task VerifyMessageAdded()
2121
{
22-
var domains = session.GetVersionSpecificDomains<V86.DevToolsSessionDomains>();
22+
var domains = session.GetVersionSpecificDomains<V87.DevToolsSessionDomains>();
2323
string consoleMessage = "Hello Selenium";
2424

2525
ManualResetEventSlim sync = new ManualResetEventSlim(false);
26-
EventHandler<V86.Console.MessageAddedEventArgs> messageAddedHandler = (sender, e) =>
26+
EventHandler<V87.Console.MessageAddedEventArgs> messageAddedHandler = (sender, e) =>
2727
{
2828
Assert.That(e.Message.Text, Is.EqualTo(consoleMessage));
2929
sync.Set();

dotnet/test/common/DevTools/DevToolsLogTest.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ public class DevToolsLogTest : DevToolsTestFixture
1919
[IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
2020
public async Task VerifyEntryAddedAndClearLog()
2121
{
22-
var domains = session.GetVersionSpecificDomains<V86.DevToolsSessionDomains>();
22+
var domains = session.GetVersionSpecificDomains<V87.DevToolsSessionDomains>();
2323
ManualResetEventSlim sync = new ManualResetEventSlim(false);
24-
EventHandler<V86.Log.EntryAddedEventArgs> entryAddedHandler = (sender, e) =>
24+
EventHandler<V87.Log.EntryAddedEventArgs> entryAddedHandler = (sender, e) =>
2525
{
2626
Assert.That(e.Entry.Text.Contains("404"));
27-
Assert.That(e.Entry.Level == V86.Log.LogEntryLevelValues.Error);
27+
Assert.That(e.Entry.Level == V87.Log.LogEntryLevelValues.Error);
2828
sync.Set();
2929
};
3030

dotnet/test/common/DevTools/DevToolsNetworkTest.cs

+75-75
Large diffs are not rendered by default.

dotnet/test/common/DevTools/DevToolsPerformanceTest.cs

+15-15
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ public class DevToolsPerformanceTest : DevToolsTestFixture
1818
[IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
1919
public async Task EnableAndDisablePerformance()
2020
{
21-
var domains = session.GetVersionSpecificDomains<V86.DevToolsSessionDomains>();
22-
await domains.Performance.Enable(new V86.Performance.EnableCommandSettings());
21+
var domains = session.GetVersionSpecificDomains<V87.DevToolsSessionDomains>();
22+
await domains.Performance.Enable(new V87.Performance.EnableCommandSettings());
2323
driver.Url = simpleTestPage;
2424
await domains.Performance.Disable();
2525
}
@@ -31,7 +31,7 @@ public async Task EnableAndDisablePerformance()
3131
[IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
3232
public async Task DisablePerformance()
3333
{
34-
var domains = session.GetVersionSpecificDomains<V86.DevToolsSessionDomains>();
34+
var domains = session.GetVersionSpecificDomains<V87.DevToolsSessionDomains>();
3535
await domains.Performance.Disable();
3636
driver.Url = simpleTestPage;
3737
await domains.Performance.Disable();
@@ -44,13 +44,13 @@ public async Task DisablePerformance()
4444
[IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
4545
public async Task SetTimeDomainTimeTickPerformance()
4646
{
47-
var domains = session.GetVersionSpecificDomains<V86.DevToolsSessionDomains>();
47+
var domains = session.GetVersionSpecificDomains<V87.DevToolsSessionDomains>();
4848
await domains.Performance.Disable();
49-
await domains.Performance.SetTimeDomain(new V86.Performance.SetTimeDomainCommandSettings()
49+
await domains.Performance.SetTimeDomain(new V87.Performance.SetTimeDomainCommandSettings()
5050
{
5151
TimeDomain = "timeTicks"
5252
});
53-
await domains.Performance.Enable(new V86.Performance.EnableCommandSettings());
53+
await domains.Performance.Enable(new V87.Performance.EnableCommandSettings());
5454
driver.Url = simpleTestPage;
5555
await domains.Performance.Disable();
5656
}
@@ -62,13 +62,13 @@ await domains.Performance.SetTimeDomain(new V86.Performance.SetTimeDomainCommand
6262
[IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
6363
public async Task SetTimeDomainsThreadTicksPerformance()
6464
{
65-
var domains = session.GetVersionSpecificDomains<V86.DevToolsSessionDomains>();
65+
var domains = session.GetVersionSpecificDomains<V87.DevToolsSessionDomains>();
6666
await domains.Performance.Disable();
67-
await domains.Performance.SetTimeDomain(new V86.Performance.SetTimeDomainCommandSettings()
67+
await domains.Performance.SetTimeDomain(new V87.Performance.SetTimeDomainCommandSettings()
6868
{
6969
TimeDomain = "threadTicks"
7070
});
71-
await domains.Performance.Enable(new V86.Performance.EnableCommandSettings());
71+
await domains.Performance.Enable(new V87.Performance.EnableCommandSettings());
7272
driver.Url = simpleTestPage;
7373
await domains.Performance.Disable();
7474
}
@@ -80,12 +80,12 @@ await domains.Performance.SetTimeDomain(new V86.Performance.SetTimeDomainCommand
8080
[IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
8181
public async Task GetMetricsByTimeTicks()
8282
{
83-
var domains = session.GetVersionSpecificDomains<V86.DevToolsSessionDomains>();
84-
await domains.Performance.SetTimeDomain(new V86.Performance.SetTimeDomainCommandSettings()
83+
var domains = session.GetVersionSpecificDomains<V87.DevToolsSessionDomains>();
84+
await domains.Performance.SetTimeDomain(new V87.Performance.SetTimeDomainCommandSettings()
8585
{
8686
TimeDomain = "timeTicks"
8787
});
88-
await domains.Performance.Enable(new V86.Performance.EnableCommandSettings());
88+
await domains.Performance.Enable(new V87.Performance.EnableCommandSettings());
8989
driver.Url = simpleTestPage;
9090
var response = await domains.Performance.GetMetrics();
9191
var metrics = response.Metrics;
@@ -101,12 +101,12 @@ await domains.Performance.SetTimeDomain(new V86.Performance.SetTimeDomainCommand
101101
[IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
102102
public async Task GetMetricsByThreadTicks()
103103
{
104-
var domains = session.GetVersionSpecificDomains<V86.DevToolsSessionDomains>();
105-
await domains.Performance.SetTimeDomain(new V86.Performance.SetTimeDomainCommandSettings()
104+
var domains = session.GetVersionSpecificDomains<V87.DevToolsSessionDomains>();
105+
await domains.Performance.SetTimeDomain(new V87.Performance.SetTimeDomainCommandSettings()
106106
{
107107
TimeDomain = "threadTicks"
108108
});
109-
await domains.Performance.Enable(new V86.Performance.EnableCommandSettings());
109+
await domains.Performance.Enable(new V87.Performance.EnableCommandSettings());
110110
driver.Url = simpleTestPage;
111111
var response = await domains.Performance.GetMetrics();
112112
var metrics = response.Metrics;

dotnet/test/common/DevTools/DevToolsProfilerTest.cs

+9-9
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public class DevToolsProfilerTest : DevToolsTestFixture
1818
[IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
1919
public async Task SimpleStartStopAndGetProfilerTest()
2020
{
21-
var domains = session.GetVersionSpecificDomains<V86.DevToolsSessionDomains>();
21+
var domains = session.GetVersionSpecificDomains<V87.DevToolsSessionDomains>();
2222
await domains.Profiler.Enable();
2323
await domains.Profiler.Start();
2424
var response = await domains.Profiler.Stop();
@@ -34,10 +34,10 @@ public async Task SimpleStartStopAndGetProfilerTest()
3434
[IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
3535
public async Task SampleGetBestEffortProfilerTest()
3636
{
37-
var domains = session.GetVersionSpecificDomains<V86.DevToolsSessionDomains>();
37+
var domains = session.GetVersionSpecificDomains<V87.DevToolsSessionDomains>();
3838
await domains.Profiler.Enable();
3939
driver.Url = simpleTestPage;
40-
await domains.Profiler.SetSamplingInterval(new V86.Profiler.SetSamplingIntervalCommandSettings()
40+
await domains.Profiler.SetSamplingInterval(new V87.Profiler.SetSamplingIntervalCommandSettings()
4141
{
4242
Interval = 30
4343
});
@@ -56,10 +56,10 @@ await domains.Profiler.SetSamplingInterval(new V86.Profiler.SetSamplingIntervalC
5656
[IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
5757
public async Task SampleSetStartPreciseCoverageTest()
5858
{
59-
var domains = session.GetVersionSpecificDomains<V86.DevToolsSessionDomains>();
59+
var domains = session.GetVersionSpecificDomains<V87.DevToolsSessionDomains>();
6060
await domains.Profiler.Enable();
6161
driver.Url = simpleTestPage;
62-
await domains.Profiler.StartPreciseCoverage(new V86.Profiler.StartPreciseCoverageCommandSettings()
62+
await domains.Profiler.StartPreciseCoverage(new V87.Profiler.StartPreciseCoverageCommandSettings()
6363
{
6464
CallCount = true,
6565
Detailed = true
@@ -82,11 +82,11 @@ await domains.Profiler.StartPreciseCoverage(new V86.Profiler.StartPreciseCoverag
8282
[IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
8383
public async Task SampleProfileEvents()
8484
{
85-
var domains = session.GetVersionSpecificDomains<V86.DevToolsSessionDomains>();
85+
var domains = session.GetVersionSpecificDomains<V87.DevToolsSessionDomains>();
8686
await domains.Profiler.Enable();
8787
driver.Url = simpleTestPage;
8888
ManualResetEventSlim startSync = new ManualResetEventSlim(false);
89-
EventHandler<V86.Profiler.ConsoleProfileStartedEventArgs> consoleProfileStartedHandler = (sender, e) =>
89+
EventHandler<V87.Profiler.ConsoleProfileStartedEventArgs> consoleProfileStartedHandler = (sender, e) =>
9090
{
9191
Assert.That(e, Is.Not.Null);
9292
startSync.Set();
@@ -99,7 +99,7 @@ public async Task SampleProfileEvents()
9999
driver.Navigate().Refresh();
100100

101101
ManualResetEventSlim finishSync = new ManualResetEventSlim(false);
102-
EventHandler<V86.Profiler.ConsoleProfileFinishedEventArgs> consoleProfileFinishedHandler = (sender, e) =>
102+
EventHandler<V87.Profiler.ConsoleProfileFinishedEventArgs> consoleProfileFinishedHandler = (sender, e) =>
103103
{
104104
Assert.That(e, Is.Not.Null);
105105
finishSync.Set();
@@ -115,7 +115,7 @@ public async Task SampleProfileEvents()
115115
await domains.Profiler.Disable();
116116
}
117117

118-
private void ValidateProfile(V86.Profiler.Profile profiler)
118+
private void ValidateProfile(V87.Profiler.Profile profiler)
119119
{
120120
Assert.That(profiler, Is.Not.Null);
121121
Assert.That(profiler.Nodes, Is.Not.Null);

dotnet/test/common/DevTools/DevToolsSecurityTest.cs

+5-5
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,17 @@ public class DevToolsSecurityTest : DevToolsTestFixture
1919
[IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
2020
public async Task LoadInsecureWebsite()
2121
{
22-
var domains = session.GetVersionSpecificDomains<V86.DevToolsSessionDomains>();
22+
var domains = session.GetVersionSpecificDomains<V87.DevToolsSessionDomains>();
2323
await domains.Security.Enable();
2424

25-
await domains.Security.SetIgnoreCertificateErrors(new V86.Security.SetIgnoreCertificateErrorsCommandSettings()
25+
await domains.Security.SetIgnoreCertificateErrors(new V87.Security.SetIgnoreCertificateErrorsCommandSettings()
2626
{
2727
Ignore = false
2828
});
2929

3030
string summary = null;
3131
ManualResetEventSlim sync = new ManualResetEventSlim(false);
32-
EventHandler<V86.Security.SecurityStateChangedEventArgs> securityStateChangedHandler = (sender, e) =>
32+
EventHandler<V87.Security.SecurityStateChangedEventArgs> securityStateChangedHandler = (sender, e) =>
3333
{
3434
summary = e.Summary;
3535
sync.Set();
@@ -52,10 +52,10 @@ await domains.Security.SetIgnoreCertificateErrors(new V86.Security.SetIgnoreCert
5252
[IgnoreBrowser(Selenium.Browser.Safari, "Safari does not support Chrome DevTools Protocol")]
5353
public async Task LoadSecureWebsite()
5454
{
55-
var domains = session.GetVersionSpecificDomains<V86.DevToolsSessionDomains>();
55+
var domains = session.GetVersionSpecificDomains<V87.DevToolsSessionDomains>();
5656
await domains.Security.Enable();
5757

58-
await domains.Security.SetIgnoreCertificateErrors(new V86.Security.SetIgnoreCertificateErrorsCommandSettings()
58+
await domains.Security.SetIgnoreCertificateErrors(new V87.Security.SetIgnoreCertificateErrorsCommandSettings()
5959
{
6060
Ignore = true
6161
});

0 commit comments

Comments
 (0)