Skip to content

Commit e9ba4e3

Browse files
authored
make isPromise() return boolean value for null and undefined cases (#6785)
* make isPromise() return boolean value for null and undefined cases updated as per the review comments * updated as per review comment #6785 (comment) * added a test
1 parent 81efd30 commit e9ba4e3

File tree

1 file changed

+17
-2
lines changed

1 file changed

+17
-2
lines changed

javascript/node/selenium-webdriver/test/lib/promise_test.js

+17-2
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,23 @@ describe('promise', function () {
5959
}
6060
})
6161

62-
const _assertIsPromise = (p) => assert.ok(promise.isPromise(p))
63-
const _assertNotPromise = (v) => assert.ok(!promise.isPromise(v))
62+
it('isPromise', () => {
63+
const v = () => {};
64+
const x = new Promise(v, v);
65+
const p = createRejectedPromise('reject');
66+
const q = Promise.resolve("resolved");
67+
assert.equal(true, promise.isPromise(x));
68+
assert.equal(true, promise.isPromise(p));
69+
assert.equal(true, promise.isPromise(q));
70+
assert.equal(false, promise.isPromise(0));
71+
assert.equal(false, promise.isPromise(false));
72+
assert.equal(false, promise.isPromise(true));
73+
assert.equal(false, promise.isPromise(null));
74+
assert.equal(false, promise.isPromise(undefined));
75+
assert.equal(false, promise.isPromise(''));
76+
assert.equal(false, promise.isPromise('promise'));
77+
assert.equal(false, promise.isPromise(v));
78+
});
6479

6580
function defer() {
6681
let d = {}

0 commit comments

Comments
 (0)