Skip to content

Commit f6715f2

Browse files
committed
[java] Changing order of parameters in decorators
1 parent 7a49f61 commit f6715f2

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

java/client/src/org/openqa/selenium/support/decorators/DefaultDecorated.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,12 @@ public Object call(Method method, Object[] args) throws Throwable {
5050

5151
@Override
5252
public void afterCall(Method method, Object result, Object[] args) {
53-
getDecorator().afterCallGlobal(this, method, result, args);
53+
getDecorator().afterCallGlobal(this, method, args, result);
5454
}
5555

5656
@Override
5757
public Object onError(Method method, InvocationTargetException e, Object[] args) throws Throwable {
58-
return getDecorator().onErrorGlobal(this, method, e, args);
58+
return getDecorator().onErrorGlobal(this, method, args, e);
5959
}
6060

6161
@Override

java/client/src/org/openqa/selenium/support/decorators/WebDriverDecorator.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,11 @@ public Object callGlobal(Decorated<?> target, Method method, Object[] args) thro
9191
return decorateResult(method.invoke(target.getOriginal(), args));
9292
}
9393

94-
public void afterCallGlobal(Decorated<?> target, Method method, Object res, Object[] args) {}
94+
public void afterCallGlobal(Decorated<?> target, Method method, Object[] args, Object res) {}
9595

96-
public Object onErrorGlobal(Decorated<?> target, Method method, InvocationTargetException e, Object[] args) throws Throwable {
96+
public Object onErrorGlobal(Decorated<?> target, Method method, Object[] args,
97+
InvocationTargetException e) throws Throwable
98+
{
9799
throw e.getTargetException();
98100
}
99101

java/client/src/org/openqa/selenium/support/events/EventFiringDecorator.java

+5-4
Original file line numberDiff line numberDiff line change
@@ -172,21 +172,22 @@ public void beforeCallGlobal(Decorated<?> target, Method method, Object[] args)
172172
}
173173

174174
@Override
175-
public void afterCallGlobal(Decorated<?> target, Method method, Object result, Object[] args) {
176-
super.afterCallGlobal(target, method, result, args);
175+
public void afterCallGlobal(Decorated<?> target, Method method, Object[] args, Object result) {
176+
super.afterCallGlobal(target, method, args, result);
177177
listeners.forEach(listener -> fireAfterEvents(listener, target, method, result, args));
178178
}
179179

180180
@Override
181-
public Object onErrorGlobal(Decorated<?> target, Method method, InvocationTargetException e, Object[] args) throws Throwable {
181+
public Object onErrorGlobal(Decorated<?> target, Method method, Object[] args,
182+
InvocationTargetException e) throws Throwable {
182183
listeners.forEach(listener -> {
183184
try {
184185
listener.onError(target.getOriginal(), method, args, e);
185186
} catch (Throwable t) {
186187
logger.log(Level.WARNING, t.getMessage(), t);
187188
}
188189
});
189-
return super.onErrorGlobal(target, method, e, args);
190+
return super.onErrorGlobal(target, method, args, e);
190191
}
191192

192193
private void fireBeforeEvents(WebDriverListener listener, Decorated<?> target, Method method, Object[] args) {

java/client/test/org/openqa/selenium/support/decorators/IntegrationTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public void beforeCallGlobal(Decorated<?> target, Method method, Object[] args)
4747
}
4848

4949
@Override
50-
public void afterCallGlobal(Decorated<?> target, Method method, Object result, Object[] args) {
50+
public void afterCallGlobal(Decorated<?> target, Method method, Object[] args, Object result) {
5151
counterAfter++;
5252
}
5353

0 commit comments

Comments
 (0)