Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reverting "Show variant aliases in error message" #2888

Open
GeeWee opened this issue Jan 29, 2025 · 0 comments
Open

Consider reverting "Show variant aliases in error message" #2888

GeeWee opened this issue Jan 29, 2025 · 0 comments

Comments

@GeeWee
Copy link

GeeWee commented Jan 29, 2025

Hi!

We just recently upgraded serde, and we're seeing the effects of #2566 being merged in. We use serde for REST APIs, and often if we rename a field, we keep the old field aliased to the new field, only for people who are already integrated in the API.

We surface serde error messages if users input wrong fields, but after this change we are now also showing the user all the "deprecated" aliases that we don't want them seeing.

I would imagine that this isn't an uncommon usage for the "alias" attribute, i.e. to map existing names to a field, while having a new canonical name.

Would you be willing to consider reverting #2566, or consider a hidden attribute to the alias, determining whether or not aliases show up in error messages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant