Skip to content

Commit f68e385

Browse files
authored
jsglue.cpp: Fix -Winconsistent-missing-override (#525)
Signed-off-by: Jonathan Schwender <[email protected]>
1 parent 18ab014 commit f68e385

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

mozjs-sys/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
name = "mozjs_sys"
33
description = "System crate for the Mozilla SpiderMonkey JavaScript engine."
44
repository.workspace = true
5-
version = "0.128.3-5"
5+
version = "0.128.3-6"
66
authors = ["Mozilla"]
77
links = "mozjs"
88
build = "build.rs"

mozjs-sys/src/jsglue.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,28 +61,28 @@ class RustJobQueue : public JS::JobQueue {
6161
RustJobQueue(const JobQueueTraps& aTraps, const void* aQueue)
6262
: mTraps(aTraps), mQueue(aQueue) {}
6363

64-
virtual JSObject* getIncumbentGlobal(JSContext* cx) {
64+
virtual JSObject* getIncumbentGlobal(JSContext* cx) override {
6565
return mTraps.getIncumbentGlobal(mQueue, cx);
6666
}
6767

6868
virtual bool enqueuePromiseJob(JSContext* cx, JS::HandleObject promise,
6969
JS::HandleObject job,
7070
JS::HandleObject allocationSite,
71-
JS::HandleObject incumbentGlobal) {
71+
JS::HandleObject incumbentGlobal) override {
7272
return mTraps.enqueuePromiseJob(mQueue, cx, promise, job, allocationSite,
7373
incumbentGlobal);
7474
}
7575

76-
virtual bool empty() const { return mTraps.empty(mQueue); }
76+
virtual bool empty() const override { return mTraps.empty(mQueue); }
7777

78-
virtual void runJobs(JSContext* cx) {
78+
virtual void runJobs(JSContext* cx) override {
7979
MOZ_ASSERT(false, "runJobs should not be invoked");
8080
}
8181

8282
bool isDrainingStopped() const override { return false; }
8383

8484
private:
85-
virtual js::UniquePtr<SavedJobQueue> saveJobQueue(JSContext* cx) {
85+
virtual js::UniquePtr<SavedJobQueue> saveJobQueue(JSContext* cx) override {
8686
MOZ_ASSERT(false, "saveJobQueue should not be invoked");
8787
return nullptr;
8888
}

0 commit comments

Comments
 (0)