Skip to content

Add User Agent request for SIP008 Subscription #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
betaxab opened this issue Oct 13, 2020 · 3 comments
Closed

Add User Agent request for SIP008 Subscription #2589

betaxab opened this issue Oct 13, 2020 · 3 comments

Comments

@betaxab
Copy link

betaxab commented Oct 13, 2020

Please read contributing guidelines. Thanks.

Is your feature request related to a problem? Please describe.
Subscription API cound not recognize Client type.

Describe the solution you'd like
Set default User-Agent to ShadowsocksAndroid/$version (Example), instead of default Dalvik/x.x.x.

Describe alternatives you've considered
May add Add a custom User-Agent field, allow users specify it should be better?

Additional context

I feel this is an useful feature, I have a Subscription API, it uses User-Agent to determine the client type, e.g. ClashForAndroid, Surfboard, ShadowsocksWindows etc. It will return corresponding configuration file according UA type.
Since it does not use any parameters, this API URL can be general used on any supported Client, no need to remember which parameters is which Client, no need to change URL parameters.

Thanks.

@Mygod
Copy link
Contributor

Mygod commented Oct 13, 2020

No.

@database64128
Copy link

shadowsocks-windows implemented this in shadowsocks/shadowsocks-windows#2978 with an added option to allow the user to override the default User-Agent. I think clients identifying themselves correctly and clearly can be helpful for small scale online configuration administrators, which in my opinion, is the primary target audience of SIP008.

@Mygod
Copy link
Contributor

Mygod commented Oct 13, 2020

The point of SIP008 is to have the same config for every client implementation. If you want to track users just use query parameters.

@Mygod Mygod closed this as completed Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants