Skip to content

CUSA03173 Bloodborne: Baldness issue #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Missake212 opened this issue Dec 23, 2024 · 16 comments
Closed

CUSA03173 Bloodborne: Baldness issue #1858

Missake212 opened this issue Dec 23, 2024 · 16 comments

Comments

@Missake212
Copy link
Contributor

Missake212 commented Dec 23, 2024

Some people reported that their character have some type of baldness issue, they're not completely bald but they do have some bald spots on their head depending on the haircut they chose during character creation, I tested in main on latest nightly and this is how it looks like on the emulator:

1223.mp4

And this is how it looks like on PS4:

1223.2.mp4

I also uploaded a comparison video on YouTube to keep the quality (since GitHub allows only up to 10MB videos) and make it easier to spot the differences: https://youtu.be/koQEddibaWg

@rafael-57
Copy link
Contributor

It's a bit of an old issue, I'm trying to isolate the guilty commit. Here's some more screenshots in the meantime:

0.5.1 latest
image

0.4 release
image

@diegolix29
Copy link
Contributor

diegolix29 commented Dec 26, 2024

im debuging which commit causes this as we cant look into old actions rn, as far i could get its between these commits im currently doing local testing as some people help me narrow it down on my fork but testing main shad old actions re pushed
image

@diegolix29
Copy link
Contributor

found it is this commit that broke the hair
image

@raphaelthegreat
Copy link
Contributor

Could you check if this PR fixes the issue #1869

@diegolix29
Copy link
Contributor

yes

@diegolix29
Copy link
Contributor

image
tried this action and is still there

https://github.com/squidbus/shadPS4/actions/runs/12497571513

@raphaelthegreat
Copy link
Contributor

Ok just to make sure, could you go back to latest commit and revert just 722a0e3 to confirm. If it is that, we can try to more selectively revert things to see which exact change broke it

@diegolix29
Copy link
Contributor

sure give me a minute will do locally rn

@diegolix29
Copy link
Contributor

diegolix29 commented Dec 26, 2024

image
i had to merge 3 files that was causing conflicts but after the revert of that commit and those merged files the hair is fixed

https://github.com/diegolix29/shadPS4/actions/runs/12498211660 here is the action for the push on the revert

and these are the files that i needed to merge for the build to compile after revert

image

@rafael-57
Copy link
Contributor

rafael-57 commented Dec 26, 2024

I can also confirm it's from that commit, I've built from main both that commit and the one before and double-checked

@Foul-Tarnished
Copy link

Help I look like Asmongold

scalp texture is not getting rendered ?

@diegolix29
Copy link
Contributor

Help I look like Asmongold

scalp texture is not getting rendered ?

diegolix29@6823aed you can build locally or use my fork just remove these two things and the hair should be there

@rafael-57
Copy link
Contributor

Tested latest main today, still present

@diegolix29
Copy link
Contributor

yea this pr prevent to make a workaround for it #1869 now i dont know where to look to hack this error

@diegolix29
Copy link
Contributor

again was able to workaround it by removing this from the code diegolix29@a5efe3e

@Hermiten
Copy link
Collaborator

Fixed with #2236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants