Skip to content

Add support for certificate revocation. #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markercm opened this issue Feb 10, 2021 · 5 comments · Fixed by #342
Closed

Add support for certificate revocation. #250

markercm opened this issue Feb 10, 2021 · 5 comments · Fixed by #342
Assignees
Labels
enhancement New feature or request

Comments

@markercm
Copy link

It would be nice to have a method for revoking certificates that exist within the Keyvault and were issued by the Acmebot.

An endpoint like /revoke-certificate similar to the /renew-certificate endpoint.

The official recommendation is to use certbot and the private key to revoke as outlined here https://letsencrypt.org/docs/revoking/ however, this requires that one run a certbot instance and download the certificate from the Keyvault.

If possible, a listing of each version from the Keyvaults with their expiration dates would be ideal way to sort them as the version string is not descriptive.

@markercm markercm added the enhancement New feature or request label Feb 10, 2021
@shibayan shibayan added this to the Backlog milestone Feb 10, 2021
@shibayan
Copy link
Owner

I don't think there is enough need to prepare a GUI, so this is a low priority.

@adagioajanes
Copy link

This would be immensely useful. Right now we must manually revoke certificates to invalidate them.

@shibayan
Copy link
Owner

Please let me know the specific use case. I would like to consider it based on that.

@adagioajanes
Copy link

adagioajanes commented Jun 22, 2021

Whenever we are done with a certificate, right now you have to call up certbot manually, and revoke the certificate. Then, you have to go into key vault to delete it to ensure it is not used anymore. This manual process is cumbersome, compared to adding a certificate.

This disconnected process can leave things in a bad configuration state. You could end up assigning a revoked certificate if you don't delete it. As you add more certificates, the chances of this happening are even higher as things get disorganized.

Or the opposite, if a certificate is deleted from key vault, and not revoked, there is always the risk (albeit a low lisk since certificates are stored in the key vault) of having old certificates out there compromised.

For sake of organization and security, having a revoke function in the application would be extremely useful.

@shibayan shibayan removed this from the Backlog milestone Oct 5, 2021
This was referenced Oct 5, 2021
@shibayan
Copy link
Owner

shibayan commented Oct 5, 2021

Certificate revocation will be addressed in the future as it could be implemented with #342.

@shibayan shibayan added this to the v4.0.0 Release milestone Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants