Skip to content

Flag to disable shared slug #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JasonHK opened this issue Jul 10, 2024 · 1 comment
Closed

Flag to disable shared slug #2154

JasonHK opened this issue Jul 10, 2024 · 1 comment
Labels

Comments

@JasonHK
Copy link

JasonHK commented Jul 10, 2024

Summary

Add a flag to Shlink, when a slug was added without a domain specified, the default domain will be explicitly added (so that other domains will not redirect this slug).

Use case

The current behaviour for Shlink is if a new slug was added with no domain specified, any domain pointed to Shlink will redirect to that long URL, unless a slug for the domain also exist. This behaviour is not ideal for a multi-domain setup.

@acelaya
Copy link
Member

acelaya commented Jul 10, 2024

This topic was brought up some time ago here #1535

You can find some context on why multi-domains work like that, and the complexities to change that behavior.

As a result of that discussion, I created an issue #1536, but later on closed it due to the lack of attention.

The type of issue means that this feature is too complex to implement, and has a lot of considerations, for the benefits of brings, so I'm going to close this.

If enough people decide to support the project, I will reconsider.

@acelaya acelaya closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2024
@github-project-automation github-project-automation bot moved this to Done in Shlink Jul 10, 2024
@acelaya acelaya removed this from Shlink Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants