refactor(core)!: remove some scripts use cases

Author: zzhenryquezz

packages/core/__tests__/in-memory-config.ts

@@ -1,6 +1,7 @@
 import AppConfig from '../config/app'
 import InMemoryDrive from './gateways/in-memory-drive'
 import InMemoryWorkspaceRepository from './repositories/in-memory-workspace-repository'
+import NodeVmEvaluation from '../gateways/evaluation/implementations/node-vm-evaluation'
 
 export default class InMemoryAppConfig extends AppConfig {
     public workspaceRepository: InMemoryWorkspaceRepository
@@ -18,7 +19,11 @@ export default class InMemoryAppConfig extends AppConfig {
             workspace: workspaceRepository,
         }
 
-        super({ repositories, drives, ...args })
+        const services: AppConfig['services'] = {
+            evaluation: new NodeVmEvaluation(),
+        }
+
+        super({ repositories, drives, services, ...args })
 
         this.workspaceRepository = workspaceRepository
         this.drive = drive

packages/core/app.ts

@@ -23,11 +23,9 @@ import ShowItem from './use-cases/show-item/show-item'
 import CreateItem from './use-cases/create-item/create-item'
 import UpdateItem from './use-cases/update-item/update-item'
 import DeleteItem from './use-cases/delete-item/delete-item'
-import ListScripts from './use-cases/list-scripts/list-scripts'
-import CreateScript from './use-cases/create-script/create-script'
-import UpdateScript from './use-cases/update-script/update-script'
-import DeleteScript from './use-cases/delete-script/delete-script'
+
 import ExecuteScript from './use-cases/execute-script/execute-script'
+
 import ShowMenu from './use-cases/show-menu/show-menu'
 import UpdateMenu from './use-cases/update-menu/update-menu'
 import UpdateDirectoryEntry from './use-cases/update-directory-entry/update-directory-entry'
@@ -64,10 +62,6 @@ function createUseCases(app: AppConfig) {
         'update-item': new UpdateItem(app),
         'delete-item': new DeleteItem(app),
 
-        'list-scripts': new ListScripts(app),
-        'create-script': new CreateScript(app),
-        'update-script': new UpdateScript(app),
-        'delete-script': new DeleteScript(app),
         'execute-script': new ExecuteScript(app),
 
         'show-menu': new ShowMenu(app),

packages/core/config/app.ts

@@ -1,8 +1,8 @@
 import CollectionFacade from '../facades/collection'
 import DriveFacade from '../facades/drive'
 import ItemFacade from '../facades/item'
-import ItemFacade from '../facades/item'
 import Drive from '../gateways/drive/drive'
+import IEvaluationService from '../gateways/evaluation/evaluation'
 import IWorkspaceRepository from '../repositories/workspace/workspace-repository'
 
 interface Repositories {
@@ -15,14 +15,20 @@ interface Facades {
     item: ItemFacade
 }
 
+interface Services {
+    evaluation: IEvaluationService
+}
+
 export default class AppConfig {
     public drives: Record<string, Drive>
     public repositories: Repositories
     public facades: Facades
+    public services: Services
 
-    constructor({ drives, repositories }: Omit<AppConfig, 'facades'>) {
+    constructor({ drives, repositories, services }: Omit<AppConfig, 'facades'>) {
         this.drives = drives
         this.repositories = repositories
+        this.services = services
 
         const driveFacade = new DriveFacade(drives)
         const collectionFacade = new CollectionFacade(driveFacade)

packages/core/use-cases/create-script/create-script.dto.ts

@@ -1,14 +1,4 @@
-declare namespace ExecuteScriptDTO {
-    export interface Input {
-        workspaceId: string
-        content: string
-    }
-
-    export interface Output {
-        logs: string[]
-        error: any
-        result: any
-    }
+export default interface ExecuteScriptDTO {
+    workspaceId: string
+    content: string
 }
-
-export default ExecuteScriptDTO

packages/core/use-cases/create-script/create-script.spec.ts

@@ -1,11 +1,13 @@
 import { test } from '@japa/runner'
+import DirectoryEntry from '../../entities/directory-entry'
 import Workspace from '../../entities/workspace'
 
 import InMemoryApp from '../../__tests__/app'
+import InMemoryAppConfig from '../../__tests__/in-memory-config'
 import ExecuteScript from './execute-script'
 
 test.group('execute-script (use-case)', (group) => {
-    const app = new InMemoryApp()
+    const app = new InMemoryAppConfig()
     const useCase = new ExecuteScript(app)
 
     let workspace: Workspace
@@ -35,8 +37,6 @@ test.group('execute-script (use-case)', (group) => {
     })
 
     test('should throw an error when trying to use import fs from "fs"', async ({ expect }) => {
-        app.memoryDrive.createFile('.is/scripts/hello.js', `import fs from "fs"`)
-
         const result = await useCase.execute({
             workspaceId: workspace.id,
             content: `import fs from "fs"`,
@@ -48,11 +48,13 @@ test.group('execute-script (use-case)', (group) => {
     test('should create a file in workspace', async ({ expect }) => {
         await useCase.execute({
             workspaceId: workspace.id,
-            content: `await workspace.drive.write("hello.txt", "Hello word")`,
+            content: `await Drive.write("hello.txt", Entry.encode("Hello word"))`,
         })
 
-        const content = await app.managers.drive.readAsString('hello.txt')
+        const content = await app.drive.read('hello.txt')
+
+        expect(content).toBeDefined()
 
-        expect(content?.toString()).toBe('Hello word')
+        expect(DirectoryEntry.decode(content!)).toBe('Hello word')
     })
 })

packages/core/use-cases/create-script/create-script.ts

@@ -1,17 +1,20 @@
 import ExecuteScriptDTO from './execute-script.dto'
-import AppService from '../../services/app-service'
-import WorkspaceService from '../../services/workspace-service'
+import AppConfig from '../../config/app'
+import DirectoryEntry from '../../entities/directory-entry'
 export default class ExecuteScript {
-    constructor(private readonly app: AppService) {}
+    constructor(private readonly app: AppConfig) {}
 
-    public async execute({
-        workspaceId,
-        content,
-    }: ExecuteScriptDTO.Input): Promise<ExecuteScriptDTO.Output> {
-        const workspace = await WorkspaceService.from(this.app, workspaceId)
+    public async execute({ workspaceId, content }: ExecuteScriptDTO) {
+        const workspace = await this.app.repositories.workspace.show(workspaceId)
 
-        const result = await this.app.evaluation.evaluate(content, { workspace })
+        const drive = this.app.facades.drive.fromWorkspace(workspace)
 
-        return result
+        const scope = {
+            Drive: drive,
+            Facades: this.app.facades,
+            Entry: DirectoryEntry,
+        }
+
+        return this.app.services.evaluation.evaluate(content, scope)
     }
 }