[chore] Upgrade NodeJS instrumentation to latest (#6162)

* Upgrade NodeJS instrumentation to latest

* Latest instrumentation requires node v18 or later, upgrading auto-instr tests

* Update npm command to match v18

* Remove ubuntu-bionic images (EOL)

Author: pjanotti

instrumentation/packaging/nodejs-agent-release.txt

@@ -1 +1 @@
-v2.15.0
+v3.1.2

packaging/tests/deployments/salt/images/Dockerfile.deb

@@ -4,7 +4,7 @@ FROM ${DISTRO_IMAGE}
 ARG DISTRO_IMAGE
 ENV DEBIAN_FRONTEND=noninteractive
 ENV SALT_VERSION=latest
-ENV NODE_VERSION=16.20.2
+ENV NODE_VERSION=18.20.8
 
 RUN apt-get update && apt-get upgrade -y -o DPkg::Options::=--force-confold
 RUN apt-get install -y software-properties-common ca-certificates wget curl apt-transport-https python3-pip vim systemd procps

packaging/tests/deployments/salt/images/Dockerfile.rpm

@@ -7,7 +7,7 @@ ARG DISTRO_IMAGE
 ARG PKG_MGR=dnf
 ENV DEBIAN_FRONTEND=noninteractive
 ENV SALT_VERSION=latest
-ENV NODE_VERSION=16.20.2
+ENV NODE_VERSION=18.20.8
 ENV container=docker
 
 # config for centos

packaging/tests/images/deb/Dockerfile.ubuntu-bionic

@@ -25,7 +25,7 @@ COPY --from=tomcat /opt/java /opt/java
 COPY instrumentation/setup-tomcat.sh /opt/
 RUN bash /opt/setup-tomcat.sh
 
-ARG NODE_VERSION=v16
+ARG NODE_VERSION=v18
 COPY instrumentation/setup-express.sh /opt
 RUN bash /opt/setup-express.sh
 

packaging/tests/instrumentation/images/deb/Dockerfile.debian-bookworm

@@ -25,7 +25,7 @@ COPY --from=tomcat /opt/java /opt/java
 COPY instrumentation/setup-tomcat.sh /opt/
 RUN bash /opt/setup-tomcat.sh
 
-ARG NODE_VERSION=v16
+ARG NODE_VERSION=v18
 COPY instrumentation/setup-express.sh /opt
 RUN bash /opt/setup-express.sh
 

packaging/tests/instrumentation/images/deb/Dockerfile.debian-bullseye

@@ -25,7 +25,7 @@ COPY --from=tomcat /opt/java /opt/java
 COPY instrumentation/setup-tomcat.sh /opt/
 RUN bash /opt/setup-tomcat.sh
 
-ARG NODE_VERSION=v16
+ARG NODE_VERSION=v18
 COPY instrumentation/setup-express.sh /opt
 RUN bash /opt/setup-express.sh
 

packaging/tests/instrumentation/images/deb/Dockerfile.ubuntu-bionic

@@ -25,7 +25,7 @@ COPY --from=tomcat /opt/java /opt/java
 COPY instrumentation/setup-tomcat.sh /opt/
 RUN bash /opt/setup-tomcat.sh
 
-ARG NODE_VERSION=v16
+ARG NODE_VERSION=v18
 COPY instrumentation/setup-express.sh /opt
 RUN bash /opt/setup-express.sh
 

packaging/tests/instrumentation/images/deb/Dockerfile.ubuntu-focal

@@ -25,7 +25,7 @@ COPY --from=tomcat /opt/java /opt/java
 COPY instrumentation/setup-tomcat.sh /opt/
 RUN bash /opt/setup-tomcat.sh
 
-ARG NODE_VERSION=v16
+ARG NODE_VERSION=v18
 COPY instrumentation/setup-express.sh /opt
 RUN bash /opt/setup-express.sh
 

packaging/tests/instrumentation/images/deb/Dockerfile.ubuntu-jammy

@@ -24,7 +24,7 @@ COPY --from=tomcat /opt/java /opt/java
 COPY instrumentation/setup-tomcat.sh /opt/
 RUN bash /opt/setup-tomcat.sh
 
-ARG NODE_VERSION=v16
+ARG NODE_VERSION=v18
 COPY instrumentation/setup-express.sh /opt
 RUN bash /opt/setup-express.sh
 

packaging/tests/instrumentation/images/deb/Dockerfile.ubuntu-noble

@@ -27,7 +27,7 @@ COPY --from=tomcat /opt/java /opt/java
 COPY instrumentation/setup-tomcat.sh /opt/
 RUN bash /opt/setup-tomcat.sh
 
-ARG NODE_VERSION=v16
+ARG NODE_VERSION=v18
 COPY instrumentation/setup-express.sh /opt
 RUN bash /opt/setup-express.sh
 

packaging/tests/instrumentation/images/rpm/Dockerfile.amazonlinux-2023

@@ -26,7 +26,7 @@ COPY --from=tomcat /opt/java /opt/java
 COPY instrumentation/setup-tomcat.sh /opt/
 RUN bash /opt/setup-tomcat.sh
 
-ARG NODE_VERSION=v16
+ARG NODE_VERSION=v18
 COPY instrumentation/setup-express.sh /opt
 RUN bash /opt/setup-express.sh
 

packaging/tests/instrumentation/images/rpm/Dockerfile.centos-8

@@ -25,7 +25,7 @@ COPY --from=tomcat /opt/java /opt/java
 COPY instrumentation/setup-tomcat.sh /opt/
 RUN bash /opt/setup-tomcat.sh
 
-ARG NODE_VERSION=v16
+ARG NODE_VERSION=v18
 COPY instrumentation/setup-express.sh /opt
 RUN bash /opt/setup-express.sh
 

packaging/tests/instrumentation/images/rpm/Dockerfile.centos-9

@@ -24,7 +24,7 @@ COPY --from=tomcat /opt/java /opt/java
 COPY instrumentation/setup-tomcat.sh /opt/
 RUN bash /opt/setup-tomcat.sh
 
-ARG NODE_VERSION=v16
+ARG NODE_VERSION=v18
 COPY instrumentation/setup-express.sh /opt
 RUN bash /opt/setup-express.sh
 

packaging/tests/instrumentation/images/rpm/Dockerfile.opensuse-15

@@ -24,7 +24,7 @@ COPY --from=tomcat /opt/java /opt/java
 COPY instrumentation/setup-tomcat.sh /opt/
 RUN bash /opt/setup-tomcat.sh
 
-ARG NODE_VERSION=v16
+ARG NODE_VERSION=v18
 COPY instrumentation/setup-express.sh /opt
 RUN bash /opt/setup-express.sh
 

packaging/tests/instrumentation/images/rpm/Dockerfile.oraclelinux-8

@@ -329,8 +329,8 @@ def test_express_instrumentation(distro, arch):
     assert pkg_path, f"{PKG_NAME} package not found"
     pkg_base = os.path.basename(pkg_path)
 
-    # minimum supported node version required for profiling
-    node_version = 16
+    # minimum supported node version
+    node_version = 18
 
     buildargs = {"NODE_VERSION": f"v{node_version}"}
 

packaging/tests/instrumentation/images/rpm/Dockerfile.oraclelinux-9

@@ -11,9 +11,7 @@ HOME=$NVM_HOME bash -c 'curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0
 NVM_DIR="$NVM_HOME/.nvm"
 [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
 
-nvm install --default ${NODE_VERSION:-v16}
-
-npm config --global set user root
+nvm install --default ${NODE_VERSION:-v18} --unsafe-perm
 
 NODE_PATH="$( npm root -g )"