[chore] Ensure entire repo is formatted in workflow (#6148)

* [chore] fmt all

* Fix fmt all workflow

* Break fmt to ensure workflow is working

* Fix formatting error, update command suggestion

Author: crobert-1

.github/workflows/build-and-test.yml

@@ -86,9 +86,9 @@ jobs:
       - name: gofmt
         run: |
           make install-tools
-          make fmt
+          make for-all CMD="make fmt"
           if ! git diff --exit-code; then
-            echo "One or more Go files are not formatted correctly. Run 'make fmt' and push the changes."
+            echo "One or more Go files are not formatted correctly. Run 'make for-all CMD="make fmt"' and push the changes."
             exit 1
           fi
 

tests/testutils/golden.go

@@ -36,9 +36,9 @@ import (
 )
 
 type metricCollectionTestOpts struct {
-	compareMetricsOptions []pmetrictest.CompareMetricsOption
 	collectorEnvVars      map[string]string
 	fileMounts            map[string]string
+	compareMetricsOptions []pmetrictest.CompareMetricsOption
 }
 
 type MetricsCollectionTestOption func(*metricCollectionTestOpts)

tests/testutils/socket_proxy.go

@@ -25,13 +25,13 @@ import (
 )
 
 type SocketProxy struct {
+	listener          net.Listener
+	t                 testing.TB
 	Path              string
 	Endpoint          string
 	ContainerEndpoint string
-	listener          net.Listener
 	wg                sync.WaitGroup
 	active            atomic.Bool
-	t                 testing.TB
 }
 
 func CreateDockerSocketProxy(t testing.TB) *SocketProxy {