Skip to content

Commit 60100fc

Browse files
committed
Fix some todos
1 parent a9cb329 commit 60100fc

File tree

3 files changed

+1
-7
lines changed

3 files changed

+1
-7
lines changed

beacon_node/beacon_chain/src/beacon_chain.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1249,10 +1249,7 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
12491249
pub fn get_blobs(&self, block_root: &Hash256) -> Result<BlobSidecarList<T::EthSpec>, Error> {
12501250
match self.store.get_blobs(block_root)? {
12511251
Some(blobs) => Ok(blobs),
1252-
None => Ok(BlobSidecarList::empty(
1253-
// TODO(pawan): fix this
1254-
self.spec.max_blobs_per_block(Epoch::new(0)) as usize,
1255-
)),
1252+
None => Ok(BlobSidecarList::empty_uninitialized()),
12561253
}
12571254
}
12581255

beacon_node/network/src/sync/network_context.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1239,8 +1239,6 @@ fn to_fixed_blob_sidecar_list<E: EthSpec>(
12391239
blobs: Vec<Arc<BlobSidecar<E>>>,
12401240
max_len: usize,
12411241
) -> Result<FixedBlobSidecarList<E>, LookupVerifyError> {
1242-
// TODO(pawan): have a method on fixed runtime vector that just initializes a raw vec with max_len = None
1243-
// to signify an empty fixed runtime vector
12441242
let mut fixed_list = FixedBlobSidecarList::new(vec![None; max_len]);
12451243
for blob in blobs.into_iter() {
12461244
let index = blob.index as usize;

consensus/types/src/chain_spec.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1176,7 +1176,6 @@ impl ChainSpec {
11761176
max_request_data_column_sidecars: default_max_request_data_column_sidecars(),
11771177
min_epochs_for_blob_sidecars_requests: 16384,
11781178
blob_sidecar_subnet_count: default_blob_sidecar_subnet_count(),
1179-
// TODO(pawan): check if gnosis preset values match
11801179
max_blobs_per_block: default_max_blobs_per_block(),
11811180

11821181
/*

0 commit comments

Comments
 (0)