Improve error when app name is missing

sindresorhus · sindresorhus · commit 7a1ea2ba131e · 2020-06-06T19:19:20.000+08:00
Fixes #54
diff --git a/cli.js b/cli.js
@@ -79,6 +79,10 @@ async function init() {
 	}
 
 	const appName = appInfo.CFBundleDisplayName || appInfo.CFBundleName;
+	if (!appName) {
+		throw new Error('The app must have `CFBundleDisplayName` or `CFBundleName` defined in its `Info.plist`.');
+	}
+
 	const dmgTitle = cli.flags.dmgTitle || appName;
 	const dmgPath = path.join(destinationPath, `${appName} ${appInfo.CFBundleShortVersionString}.dmg`);
 

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,10 @@ async function init() {`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`const appName = appInfo.CFBundleDisplayName \|\| appInfo.CFBundleName;`
	`82`	`+ if (!appName) {`
	`83`	+ throw new Error('The app must have `CFBundleDisplayName` or `CFBundleName` defined in its `Info.plist`.');
	`84`	`+ }`
	`85`	`+`
`82`	`86`	`const dmgTitle = cli.flags.dmgTitle \|\| appName;`
`83`	`87`	const dmgPath = path.join(destinationPath, `${appName} ${appInfo.CFBundleShortVersionString}.dmg`);
`84`	`88`