Skip to content

Commit 3889163

Browse files
authored
Update @typescript-eslint/parser to v7 (#2313)
1 parent 8ca00a4 commit 3889163

File tree

3 files changed

+3
-34
lines changed

3 files changed

+3
-34
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
"@babel/core": "^7.23.6",
7272
"@babel/eslint-parser": "^7.23.3",
7373
"@lubien/fixture-beta-package": "^1.0.0-beta.1",
74-
"@typescript-eslint/parser": "^6.15.0",
74+
"@typescript-eslint/parser": "^7.5.0",
7575
"ava": "^6.0.1",
7676
"c8": "^8.0.1",
7777
"chalk": "^5.3.0",

rules/no-useless-switch-case.js

+2-16
Original file line numberDiff line numberDiff line change
@@ -16,31 +16,17 @@ const create = context => ({
1616
* SwitchStatement(switchStatement) {
1717
const {cases} = switchStatement;
1818

19-
// TypeScript allows multiple `default` cases
20-
const defaultCases = cases.filter(switchCase => switchCase.test === null);
21-
if (defaultCases.length !== 1) {
22-
return;
23-
}
24-
25-
const [defaultCase] = defaultCases;
26-
2719
// We only check cases where the last case is the `default` case
28-
if (defaultCase !== cases.at(-1)) {
20+
if (cases.length < 2 || cases.at(-1).test !== null) {
2921
return;
3022
}
3123

32-
const uselessCases = [];
33-
3424
for (let index = cases.length - 2; index >= 0; index--) {
3525
const node = cases[index];
36-
if (isEmptySwitchCase(node)) {
37-
uselessCases.unshift(node);
38-
} else {
26+
if (!isEmptySwitchCase(node)) {
3927
break;
4028
}
41-
}
4229

43-
for (const node of uselessCases) {
4430
yield {
4531
node,
4632
loc: getSwitchCaseHeadLocation(node, context.sourceCode),

test/no-useless-switch-case.mjs

-17
Original file line numberDiff line numberDiff line change
@@ -160,20 +160,3 @@ test.snapshot({
160160
`,
161161
],
162162
});
163-
164-
test.typescript({
165-
valid: [
166-
outdent`
167-
switch (1) {
168-
default:
169-
handleDefaultCase1();
170-
break;
171-
case 1:
172-
default:
173-
handleDefaultCase2();
174-
break;
175-
}
176-
`,
177-
],
178-
invalid: [],
179-
});

0 commit comments

Comments
 (0)