Merge pull request microsoft#89 from saikrishnav/stackoverflowfix

Fix the stackoverflow by removing multi-registration of converters

Author: Sai Krishna V

src/Microsoft.TestPlatform.ObjectModel/TestObject.cs

@@ -17,6 +17,15 @@ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel
     [DataContract]
     public abstract class TestObject
     {
+        static TestObject()
+        {
+            // Do TypeConverter registrations in static constructor only to avoid multiple registrations
+            // If we register too much, deserialization of large number of testobjects will cause StackOverflow exception
+            TypeDescriptor.AddAttributes(typeof(Guid), new TypeConverterAttribute(typeof(CustomGuidConverter)));
+            TypeDescriptor.AddAttributes(typeof(KeyValuePair<string, string>[]), new TypeConverterAttribute(typeof(CustomKeyValueConverter)));
+            TypeDescriptor.AddAttributes(typeof(string[]), new TypeConverterAttribute(typeof(CustomStringArrayConverter)));
+        }
+
         #region Fields
 
         /// <summary>
@@ -64,9 +73,6 @@ private List<KeyValuePair<TestProperty, object>> StoreKeyValuePairs
         protected TestObject()
         {
             this.store = new Dictionary<TestProperty, object>();            
-            TypeDescriptor.AddAttributes(typeof(Guid), new TypeConverterAttribute(typeof(CustomGuidConverter)));
-            TypeDescriptor.AddAttributes(typeof(KeyValuePair<string, string>[]), new TypeConverterAttribute(typeof(CustomKeyValueConverter)));
-            TypeDescriptor.AddAttributes(typeof(string[]), new TypeConverterAttribute(typeof(CustomStringArrayConverter)));
         }
 
         [OnSerializing]