Fixed partial alpha in ICO and CUR images

slouken · slouken · commit be3ddf22568d · 2025-02-10T11:30:53.000-08:00
Fixes libsdl-org#518
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -1,3 +1,6 @@
+3.2.2:
+ * Fixed partial alpha in ICO and CUR images
+
 3.0.0:
  * Added support for loading HDR AVIF images
  * Added AVIF save support:
diff --git a/src/IMG_bmp.c b/src/IMG_bmp.c
@@ -403,7 +403,7 @@ LoadICOCUR_IO(SDL_IOStream * src, int type, bool closeio)
                     goto done;
                 }
             }
-            *((Uint32 *) bits + i) |= ((pixel >> shift) ? 0 : 0xFF000000);
+            *((Uint32 *) bits + i) &= ((pixel >> shift) ? 0 : 0xFFFFFFFF);
             pixel <<= ExpandBMP;
         }
         /* Skip padding bytes, ugh */

Original file line number	Diff line number	Diff line change
`@@ -403,7 +403,7 @@ LoadICOCUR_IO(SDL_IOStream * src, int type, bool closeio)`
`403`	`403`	`goto done;`
`404`	`404`	`}`
`405`	`405`	`}`
`406`		`- ((Uint32 ) bits + i) \|= ((pixel >> shift) ? 0 : 0xFF000000);`
	`406`	`+ ((Uint32 ) bits + i) &= ((pixel >> shift) ? 0 : 0xFFFFFFFF);`
`407`	`407`	`pixel <<= ExpandBMP;`
`408`	`408`	`}`
`409`	`409`	`/* Skip padding bytes, ugh */`