Skip to content

Commit 777d613

Browse files
Revert "update formating, linting, and some dependencies (#1117)"
This reverts commit 0fd3e48.
1 parent 0fd3e48 commit 777d613

File tree

245 files changed

+5536
-5134
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

245 files changed

+5536
-5134
lines changed

.eslintrc.json

+45
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
{
2+
"ignorePatterns": ["node_modules/", "dist/"],
3+
"env": {
4+
"browser": true,
5+
"es2021": true
6+
},
7+
"extends": [
8+
"eslint:recommended",
9+
"plugin:@typescript-eslint/recommended",
10+
"plugin:solid/typescript"
11+
],
12+
"overrides": [
13+
{
14+
"env": {
15+
"node": true
16+
},
17+
"files": [".eslintrc.{js,cjs}"],
18+
"parserOptions": {
19+
"sourceType": "script"
20+
}
21+
}
22+
],
23+
"parser": "@typescript-eslint/parser",
24+
"parserOptions": {
25+
"ecmaVersion": "latest",
26+
"sourceType": "module"
27+
},
28+
"plugins": ["@typescript-eslint", "solid"],
29+
"rules": {
30+
"quotes": ["error", "double"],
31+
"semi": "warn",
32+
"@typescript-eslint/no-unused-vars": [
33+
"error",
34+
{
35+
"args": "all",
36+
"argsIgnorePattern": "^_",
37+
"caughtErrors": "all",
38+
"caughtErrorsIgnorePattern": "^_",
39+
"destructuredArrayIgnorePattern": "^_",
40+
"varsIgnorePattern": "^_",
41+
"ignoreRestSiblings": true
42+
}
43+
]
44+
}
45+
}

.github/ISSUE_TEMPLATE/BUGS.yml

+10-7
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
name: "Bug Report 🪲"
22
description: Report an issue or possible bug with the functionality of the Solid docs website. (Not related to the content of the site.)
33
title: "[Bug]: "
4-
labels: ["bug", "pending review"]
5-
assignees:
6-
- danieljcafonso
7-
- atilafassina
4+
labels: [
5+
"bug",
6+
"pending review"
7+
]
8+
assignees:
9+
- danieljcafonso
10+
- atilafassina
811

912
body:
1013
- type: textarea
@@ -22,21 +25,21 @@ body:
2225
description: Please indicate on which page(s) the issue occurs.
2326
placeholder: https://docs.solidjs.com/concepts/intro-to-reactivity
2427
validations:
25-
required: true
28+
required: true
2629
- type: textarea
2730
id: expected
2831
attributes:
2932
label: "🤔 Expected Behavior"
3033
description: Please describe what the expected behavior should be.
31-
placeholder: When on this page, I expected . . .
34+
placeholder: When on this page, I expected . . .
3235
validations:
3336
required: true
3437
- type: textarea
3538
id: current
3639
attributes:
3740
label: "👀 Current Behavior"
3841
description: Please describe what the current behavior is.
39-
placeholder: But instead, on this page I'm noticing . . .
42+
placeholder: But instead, on this page I'm noticing . . .
4043
validations:
4144
required: true
4245
- type: input

.github/ISSUE_TEMPLATE/CONTENT.yml

+8-6
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
name: "Content Report 📄"
22
title: "[Content]:"
33
description: Report an issue with existing content.
4-
labels: ["improve documentation", "pending review"]
5-
assignees:
6-
- ladybluenotes
4+
labels: [
5+
"improve documentation", "pending review"
6+
]
7+
assignees:
8+
- ladybluenotes
79
body:
810
- type: markdown
911
attributes:
@@ -23,19 +25,19 @@ body:
2325
description: Please provide the URL of the page(s) affected.
2426
placeholder: https://docs.solidjs.com/concepts/intro-to-reactivity
2527
validations:
26-
required: true
28+
required: true
2729
- type: textarea
2830
id: generalDesc
2931
attributes:
3032
label: "📋 Description of content that is out-of-date or incorrect"
3133
description: Let us know what's wrong!
3234
placeholder: "..."
3335
validations:
34-
required: true
36+
required: true
3537
- type: textarea
3638
id: incorrectContent
3739
attributes:
3840
label: "🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)"
3941
description: If you are reporting incorrect content or code samples, you can also attach a reproduction in stackblitz.
4042
validations:
41-
required: false
43+
required: false

.github/ISSUE_TEMPLATE/OTHER.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
name: "Other Report 🌐"
22
title: "[Other]:"
33
description: Report something else we should know about the docs site!
4-
labels: ["pending review"]
4+
labels: [
5+
"pending review"
6+
]
57
body:
68
- type: textarea
79
id: issue
@@ -10,4 +12,4 @@ body:
1012
description: Please describe the problem with the documentation in detail.
1113
placeholder: "..."
1214
validations:
13-
required: true
15+
required: true

.github/ISSUE_TEMPLATE/REQUEST.yml

+8-6
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
name: "Request 💡"
22
title: "[Request]:"
33
description: Share an idea.
4-
labels: ["request", "pending review"]
4+
labels: [
5+
"request", "pending review"
6+
]
57
assignees:
6-
- ladybluenotes
8+
- ladybluenotes
79
body:
810
- type: markdown
911
attributes:
@@ -12,7 +14,7 @@ body:
1214
id: request-topic
1315
attributes:
1416
label: "What is this request related to?"
15-
options:
17+
options:
1618
- Request
1719
- Styling
1820
- Feature
@@ -25,20 +27,20 @@ body:
2527
description: Please provide the URL of the page(s) or section this idea is related to.
2628
placeholder: https://docs.solidjs.com/concepts/intro-to-reactivity
2729
validations:
28-
required: false
30+
required: false
2931
- type: textarea
3032
id: generalDesc
3133
attributes:
3234
label: "📋 General description or bullet points"
3335
description: Please provide a general description or bullet points about what you would like to see added.
3436
placeholder: "..."
3537
validations:
36-
required: true
38+
required: true
3739
- type: textarea
3840
id: example
3941
attributes:
4042
label: "🖥️ Reproduction of code samples in StackBlitz"
4143
description: If you would like to suggest code samples please attach a working reproduction.
4244
placeholder: "..."
4345
validations:
44-
required: false
46+
required: false

.github/ISSUE_TEMPLATE/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ blank_issues_enabled: true
22
contact_links:
33
- name: Support & Community 💁
44
url: https://discord.com/invite/solidjs
5-
about: "This issue tracker is not for support questions. Our Discord server hosts the community of Solid users. Come join us to discuss Solid or find assistance!"
5+
about: 'This issue tracker is not for support questions. Our Discord server hosts the community of Solid users. Come join us to discuss Solid or find assistance!'

.github/PULL_REQUEST_TEMPLATE.md

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
- [ ] This PR references an issue (except for typos, broken links, or other minor problems)
55

66
### Description(required)
7-
87
<!-- Provide a detailed description of the changes in this PR. Why is it necessary, and what does it do? -->
98

109
### Related issues & labels

.github/actions/install/action.yml

-21
This file was deleted.

.github/workflows/format.yml

-21
This file was deleted.

.github/workflows/static_checks.yml

+51-18
Original file line numberDiff line numberDiff line change
@@ -2,37 +2,70 @@ name: 🔍 Lint / Type Checks
22

33
on:
44
push:
5-
branches:
6-
- main
7-
5+
branches: [main]
86
pull_request:
9-
branches:
10-
- main
7+
branches: [main]
118

129
jobs:
13-
typecheck:
10+
setup:
1411
runs-on: ubuntu-latest
1512
steps:
16-
- name: Check out code
17-
uses: actions/checkout@v4
18-
19-
- name: Install tools & dependencies
20-
uses: ./.github/actions/install
13+
- uses: actions/checkout@v4
14+
- uses: pnpm/action-setup@v4
15+
with:
16+
version: 9
17+
- uses: actions/setup-node@v4
18+
with:
19+
node-version: "20"
20+
cache: "pnpm"
21+
- run: pnpm i
22+
- uses: actions/cache/save@v4
23+
with:
24+
path: |
25+
node_modules
26+
~/.pnpm-store
27+
key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
2128

29+
typecheck:
30+
needs: setup
31+
runs-on: ubuntu-latest
32+
steps:
33+
- uses: actions/checkout@v4
34+
- uses: pnpm/action-setup@v4
35+
with:
36+
version: 9
37+
- uses: actions/setup-node@v4
38+
with:
39+
node-version: "20"
40+
cache: "pnpm"
41+
- uses: actions/cache/restore@v4
42+
with:
43+
path: |
44+
node_modules
45+
~/.pnpm-store
46+
key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
2247
- name: Generate virtual modules
2348
run: pnpm sync
24-
2549
- name: TypeScript check
2650
run: pnpm check:types
2751

2852
lint:
53+
needs: setup
2954
runs-on: ubuntu-latest
3055
steps:
31-
- name: Check out code
32-
uses: actions/checkout@v4
33-
34-
- name: Install tools & dependencies
35-
uses: ./.github/actions/install
36-
56+
- uses: actions/checkout@v4
57+
- uses: pnpm/action-setup@v4
58+
with:
59+
version: 9
60+
- uses: actions/setup-node@v4
61+
with:
62+
node-version: "20"
63+
cache: "pnpm"
64+
- uses: actions/cache/restore@v4
65+
with:
66+
path: |
67+
node_modules
68+
~/.pnpm-store
69+
key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
3770
- name: ESLint check
3871
run: pnpm check:lint

.prettierrc

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
2+
"trailingComma": "es5",
23
"tabWidth": 2,
34
"semi": true,
45
"singleQuote": false,

0 commit comments

Comments
 (0)