Upgrade to TypeScript 5.0, get typechecking working but build still broken

Need to make some decisions about whether/how to emit CJS modules,
because as long as we have verbatimModuleSyntax enabled, we cannot
use the typical `export const = "x"` format, and tsc-multi rewriting
is also now breaking for this on v5, and patching it to do the rewrites
may be non trivial since it can involve shifting large blocks of code.

Alternatively we could just not opt into the flag, in which case
we should also restore the `isolatedModules` flag (which was removed
as redunant).

See:

* https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#verbatimmodulesyntax
* microsoft/TypeScript#52203
* tommy351/tsc-multi#19

Author: milesrichardson

package.json

@@ -16,7 +16,7 @@
     "prettier": "2.7.1",
     "rimraf": "3.0.2",
     "tsc-multi": "0.6.1",
-    "typescript": "4.9.5",
+    "typescript": "5.0.2",
     "undici": "5.10.0",
     "verdaccio": "5.13.1",
     "vitest": "0.22.1",

packages/base-db/base-db.ts

@@ -1,10 +1,10 @@
 import type { Plugin } from "./plugin-bindings";
 import {
-  WithPluginRegistry,
+  type WithPluginRegistry,
   PluginRegistry,
-  PluggableInterfaceShape,
-  PluginList,
-  ExtractPlugin,
+  type PluggableInterfaceShape,
+  type PluginList,
+  type ExtractPlugin,
 } from "./plugin-registry";
 
 import {

packages/base-db/plugin-registry.test.ts

@@ -5,9 +5,9 @@ import type {
   NotEqual,
 } from "@madatdata/test-helpers/type-test-utils";
 import {
-  PluginList,
+  type PluginList,
   PluginRegistry,
-  WithPluginRegistry,
+  type WithPluginRegistry,
 } from "./plugin-registry";
 
 type SomeKindOfChampionPlugin = {

packages/client-http/client-http.ts

@@ -6,11 +6,11 @@ import {
   type Database,
   type Host,
   type UnknownCredential,
-  UnknownRowShape,
-  ExecutionResultWithObjectShapedRows,
-  ExecutionResultWithArrayShapedRows,
-  UnknownArrayShape,
-  UnknownObjectShape,
+  type UnknownRowShape,
+  type ExecutionResultWithObjectShapedRows,
+  type ExecutionResultWithArrayShapedRows,
+  type UnknownArrayShape,
+  type UnknownObjectShape,
 } from "@madatdata/base-client";
 
 export interface WebBridgeResponse<RowShape extends UnknownRowShape> {

packages/db-seafowl/db-seafowl.ts

@@ -7,7 +7,7 @@ import {
   type ExportPlugin,
   type ExtractPlugin,
   type PluginList,
-  WithOptionsInterface,
+  type WithOptionsInterface,
 } from "@madatdata/base-db";
 
 // TODO: This sould be injected in the constructor as the actual plugin map

packages/db-splitgraph/db-splitgraph.ts

@@ -2,11 +2,11 @@ import {
   BaseDb,
   type DbOptions,
   type DbPluggableInterface,
-  WithPluginRegistry,
-  ImportPlugin,
-  ExportPlugin,
-  PluginList,
-  ExtractPlugin,
+  type WithPluginRegistry,
+  type ImportPlugin,
+  type ExportPlugin,
+  type PluginList,
+  type ExtractPlugin,
   type WithOptionsInterface,
 } from "@madatdata/base-db";
 

packages/db-splitgraph/plugins/exporters/export-query-plugin.ts

@@ -1,6 +1,9 @@
 import type { ExportPlugin, WithOptionsInterface } from "@madatdata/base-db";
 import { SplitgraphGraphQLClient } from "../../gql-client/splitgraph-graphql-client";
-import { ExportFormat, ExportJobOutput } from "../../gql-client/unified-types";
+import {
+  ExportFormat,
+  type ExportJobOutput,
+} from "../../gql-client/unified-types";
 import { Retryable, BackOffPolicy } from "typescript-retry-decorator";
 
 import { gql } from "graphql-request";

packages/yeet/package.json

@@ -7,11 +7,11 @@
     "yeet-debug": "yarn run esno --inspect-brk=127.0.0.1:9229 start.ts"
   },
   "dependencies": {
-    "@rushstack/ts-command-line": "4.12.1",
+    "@rushstack/ts-command-line": "4.13.2",
     "chalk": "5.0.1",
     "esno": "0.16.3",
     "playwright": "1.23.2",
-    "typescript": "4.9.5"
+    "typescript": "5.0.2"
   },
   "devDependencies": {
     "@types/node": "18.7.13"

tsconfig.base-noncomposite-esno.json

@@ -3,6 +3,7 @@
   "compilerOptions": {
     "noEmit": true,
     "emitDeclarationOnly": false,
-    "module": "commonjs"
+    "module": "commonjs",
+    "verbatimModuleSyntax": false
   }
 }

tsconfig.base.json

@@ -16,13 +16,12 @@
     "module": "esnext",
     "moduleResolution": "node",
     "resolveJsonModule": true,
-    "isolatedModules": true,
     "jsx": "react-jsx",
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noFallthroughCasesInSwitch": true,
     "noPropertyAccessFromIndexSignature": true,
-    "importsNotUsedAsValues": "error",
+    "verbatimModuleSyntax": true,
     "incremental": true,
     "baseUrl": ".",
     "composite": true,

tsconfig.build-base.json

@@ -3,7 +3,6 @@
   "extends": "./tsconfig.base.json",
   "compilerOptions": {
     "emitDeclarationOnly": false,
-    "resolveJsonModule": false,
-    "isolatedModules": false
+    "resolveJsonModule": false
   }
 }

yarn.lock

@@ -1783,7 +1783,7 @@ __metadata:
     prettier: 2.7.1
     rimraf: 3.0.2
     tsc-multi: 0.6.1
-    typescript: 4.9.5
+    typescript: 5.0.2
     undici: 5.10.0
     verdaccio: 5.13.1
     vitest: 0.22.1
@@ -1832,12 +1832,12 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@madatdata/yeet@workspace:packages/yeet"
   dependencies:
-    "@rushstack/ts-command-line": 4.12.1
+    "@rushstack/ts-command-line": 4.13.2
     "@types/node": 18.7.13
     chalk: 5.0.1
     esno: 0.16.3
     playwright: 1.23.2
-    typescript: 4.9.5
+    typescript: 5.0.2
   languageName: unknown
   linkType: soft
 
@@ -1930,15 +1930,15 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@rushstack/ts-command-line@npm:4.12.1":
-  version: 4.12.1
-  resolution: "@rushstack/ts-command-line@npm:4.12.1"
+"@rushstack/ts-command-line@npm:4.13.2":
+  version: 4.13.2
+  resolution: "@rushstack/ts-command-line@npm:4.13.2"
   dependencies:
     "@types/argparse": 1.0.38
     argparse: ~1.0.9
     colors: ~1.2.1
     string-argv: ~0.3.1
-  checksum: e9479bd001f4f206d207c867ec7b91444727cf8a1c685dac7589c6a33b54f47200deabc450d6831a1cc38501f0322eb7003c1f78f1fa43230541c4b7ddc4718d
+  checksum: 3938e533e08d5cf4007a651d1aab658a7a60d6136a56414e2370b64434657a5d5a9eff442da4ddc260d5e6dc90f82428de64dbcfa1285e9ae176629f7fcd821d
   languageName: node
   linkType: hard
 
@@ -9153,23 +9153,23 @@ __metadata:
   languageName: node
   linkType: hard
 
-"typescript@npm:4.9.5":
-  version: 4.9.5
-  resolution: "typescript@npm:4.9.5"
+"typescript@npm:5.0.2":
+  version: 5.0.2
+  resolution: "typescript@npm:5.0.2"
   bin:
     tsc: bin/tsc
     tsserver: bin/tsserver
-  checksum: ee000bc26848147ad423b581bd250075662a354d84f0e06eb76d3b892328d8d4440b7487b5a83e851b12b255f55d71835b008a66cbf8f255a11e4400159237db
+  checksum: bef1dcd166acfc6934b2ec4d72f93edb8961a5fab36b8dd2aaf6f4f4cd5c0210f2e0850aef4724f3b4913d5aef203a94a28ded731b370880c8bcff7e4ff91fc1
   languageName: node
   linkType: hard
 
-"typescript@patch:typescript@4.9.5#~builtin<compat/typescript>":
-  version: 4.9.5
-  resolution: "typescript@patch:typescript@npm%3A4.9.5#~builtin<compat/typescript>::version=4.9.5&hash=f456af"
+"typescript@patch:typescript@5.0.2#~builtin<compat/typescript>":
+  version: 5.0.2
+  resolution: "typescript@patch:typescript@npm%3A5.0.2#~builtin<compat/typescript>::version=5.0.2&hash=f456af"
   bin:
     tsc: bin/tsc
     tsserver: bin/tsserver
-  checksum: 2eee5c37cad4390385db5db5a8e81470e42e8f1401b0358d7390095d6f681b410f2c4a0c496c6ff9ebd775423c7785cdace7bcdad76c7bee283df3d9718c0f20
+  checksum: bdbf3d0aac0d6cf010fbe0536753dc19f278eb4aba88140dcd25487dfe1c56ca8b33abc0dcd42078790a939b08ebc4046f3e9bb961d77d3d2c3cfa9829da4d53
   languageName: node
   linkType: hard