Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit e7dcb57

Browse files
authored
fix: Update viewLog accessibility on task page
Resolves #1814
1 parent 4cef3d0 commit e7dcb57

File tree

3 files changed

+3
-12
lines changed

3 files changed

+3
-12
lines changed

ui/src/app/tasks-jobs/executions/execution/execution.component.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,7 @@ export class ExecutionComponent implements OnInit {
117117
}
118118

119119
hasLog(): boolean {
120-
return (
121-
(this.execution.taskExecutionStatus === 'COMPLETE' || this.execution.taskExecutionStatus === 'ERROR') &&
122-
!!this.execution.externalExecutionId
123-
);
120+
return !!this.execution.externalExecutionId;
124121
}
125122

126123
log(): void {

ui/src/app/tasks-jobs/jobs/execution/execution.component.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,7 @@ export class ExecutionComponent implements OnInit {
147147
}
148148

149149
hasLog(): boolean {
150-
return (
151-
(this.taskExecution.taskExecutionStatus === 'COMPLETE' || this.taskExecution.taskExecutionStatus === 'ERROR') &&
152-
this.taskExecution.externalExecutionId !== ''
153-
);
150+
return this.taskExecution.externalExecutionId !== '';
154151
}
155152

156153
viewLog(): void {

ui/src/app/tasks-jobs/tasks/task/task.component.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,10 +152,7 @@ export class TaskComponent implements OnInit {
152152
}
153153

154154
hasLog(execution: TaskExecution): boolean {
155-
return (
156-
(execution.taskExecutionStatus === 'COMPLETE' || execution.taskExecutionStatus === 'ERROR') &&
157-
execution.externalExecutionId !== ''
158-
);
155+
return execution.externalExecutionId !== '';
159156
}
160157

161158
openLog(execution: TaskExecution): void {

0 commit comments

Comments
 (0)