Skip to content

Commit 9eb7260

Browse files
committed
Polish RSocket server support
Relax the `NettyRSocketBootstrap` contract to allow all types of `SocketAcceptor` implementations. See gh-16021
1 parent 2112e02 commit 9eb7260

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/rsocket/RSocketServerAutoConfiguration.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
import io.netty.buffer.PooledByteBufAllocator;
2222
import io.rsocket.RSocketFactory;
23+
import io.rsocket.SocketAcceptor;
2324

2425
import org.springframework.beans.factory.ObjectProvider;
2526
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
@@ -106,9 +107,8 @@ public RSocketServerFactory rSocketServerFactory(RSocketProperties properties,
106107
@Bean
107108
public NettyRSocketBootstrap nettyRSocketBootstrap(
108109
RSocketServerFactory rSocketServerFactory,
109-
MessageHandlerAcceptor messageHandlerAcceptor) {
110-
return new NettyRSocketBootstrap(rSocketServerFactory,
111-
messageHandlerAcceptor);
110+
SocketAcceptor socketAcceptor) {
111+
return new NettyRSocketBootstrap(rSocketServerFactory, socketAcceptor);
112112
}
113113

114114
}

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/rsocket/netty/NettyRSocketBootstrap.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,14 @@
1616

1717
package org.springframework.boot.rsocket.netty;
1818

19+
import io.rsocket.SocketAcceptor;
20+
1921
import org.springframework.boot.rsocket.context.RSocketServerInitializedEvent;
2022
import org.springframework.boot.rsocket.server.RSocketServer;
2123
import org.springframework.boot.rsocket.server.RSocketServerFactory;
2224
import org.springframework.context.ApplicationEventPublisher;
2325
import org.springframework.context.ApplicationEventPublisherAware;
2426
import org.springframework.context.SmartLifecycle;
25-
import org.springframework.messaging.rsocket.MessageHandlerAcceptor;
2627

2728
/**
2829
* Bootstrap an {@link RSocketServer} and start it with the application context.
@@ -38,8 +39,8 @@ public class NettyRSocketBootstrap
3839
private ApplicationEventPublisher applicationEventPublisher;
3940

4041
public NettyRSocketBootstrap(RSocketServerFactory serverFactoryProvider,
41-
MessageHandlerAcceptor messageHandlerAcceptorProvider) {
42-
this.rSocketServer = serverFactoryProvider.create(messageHandlerAcceptorProvider);
42+
SocketAcceptor socketAcceptor) {
43+
this.rSocketServer = serverFactoryProvider.create(socketAcceptor);
4344
}
4445

4546
@Override

0 commit comments

Comments
 (0)