Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple paths to disk space health check #18359

Closed
cyterdan opened this issue Sep 25, 2019 · 5 comments
Closed

Add multiple paths to disk space health check #18359

cyterdan opened this issue Sep 25, 2019 · 5 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

Comments

@cyterdan
Copy link

cyterdan commented Sep 25, 2019

Current configuration for disk space monitoring looks like this:

management.health.diskspace.path=/var/log/tomcat8

I have a requirement to monitor multiple paths.
If you think that's useful, I can take this on and create a PR.

Thanks

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 25, 2019
@philwebb
Copy link
Member

Thanks for the suggestion @cyterdan, I think it would be a worthwhile enhancement. It should be possible to update DiskSpaceHealthIndicator to accept a collection of path/threshold pairs. If you're interested in creating a PR, this would be most welcome.

@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 27, 2019
@philwebb philwebb added this to the General Backlog milestone Sep 27, 2019
@eddumelendez
Copy link
Contributor

Hi, I would like to work on this with a friend @manduinca. Can we take it?

I think we should keep backward compatibility, right?

WDYT about having the following properties?

management.health.diskspace.<alias>.path=
management.health.diskspace.<alias>.threshold=

@snicoll
Copy link
Member

snicoll commented Oct 2, 2019

@eddumelendez thanks for the offer but the issue is already assigned. See #18413

@eddumelendez
Copy link
Contributor

thanks @snicoll

@wilkinsona
Copy link
Member

As described in #27306 (comment), we have decided that we do not want to add support for configuring the disk space health indicator with multiple paths.

@wilkinsona wilkinsona removed this from the General Backlog milestone Aug 23, 2021
@wilkinsona wilkinsona added the status: declined A suggestion or change that we don't feel we should currently apply label Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants