Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate WebServer-specific WebServerFactoryCustomizer implementations #44067

Open
wilkinsona opened this issue Feb 4, 2025 · 1 comment
Open

Relocate WebServer-specific WebServerFactoryCustomizer implementations #44067

wilkinsona opened this issue Feb 4, 2025 · 1 comment
Assignees
@wilkinsona
Labels
status: pending-design-work Needs design work before any code can be developed theme: structure Issues related to the structure of the project and its code type: task A general task
Milestone
4.0.x

Comments

@wilkinsona
Copy link
Member

TomcatServletWebServerFactoryCustomizer and UndertowServletWebServerFactoryCustomizer are both currently in org.springframework.boot.autoconfigure.web.servlet and they apply Undertow- and Tomcat-specific server properties respectively. Similarly TomcatReactiveWebServerFactoryCustomizer is currently in org.springframework.boot.autoconfigure.web.reactive and applies Tomcat-specific server properties.

As a follow-on from #44064, these server-specific customisers should move into packages that are server-specific. We'll need to figure out if we want a package per supported web server or if we want servlet and reactive sub-packages.
@wilkinsona wilkinsona added status: pending-design-work Needs design work before any code can be developed theme: structure Issues related to the structure of the project and its code type: task A general task labels Feb 4, 2025
@wilkinsona wilkinsona modified the milestones: 3.5.x, 4.0.x Feb 4, 2025
@wilkinsona
Copy link
Member Author

#24706 is related to this. To keep the current behvavior, the customizers must continue to take effect even when there's a user defined factory for the web server.

@wilkinsona wilkinsona self-assigned this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
status: pending-design-work Needs design work before any code can be developed theme: structure Issues related to the structure of the project and its code type: task A general task
Projects
None yet
Milestone
4.0.x
Development

No branches or pull requests
1 participant
@wilkinsona